Commit Graph

41802 Commits

Author SHA1 Message Date
Allan Nordhøy e037bae7ad
Spelling: No ...., upgrades and email. 2018-01-02 09:47:54 +01:00
Roeland Jago Douma a2a4a5596d
Merge pull request #7646 from nextcloud/no_exction_logging_appstore_timeout
Don't spam the log when we could not properly connect to the appstore
2018-01-02 09:29:38 +01:00
Roeland Jago Douma 752055220f
Don't spam the log when we could not properly connect to the appstore
If we can't connect to the appstore for some reason we don't have to log
the exception just an info entry is enough.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-29 15:55:05 +01:00
Roeland Jago Douma ea858fcb55
Merge pull request #7626 from nextcloud/fixed-files-multiselect-top-margin
Fixed top position of multiselected files table
2017-12-28 11:22:44 +01:00
Roeland Jago Douma 08cbfb6c6b
Merge pull request #7592 from nextcloud/update-quota-on-files-upload
Update quota on files upload
2017-12-28 10:53:14 +01:00
Roeland Jago Douma 46958e4c3f
Merge pull request #7608 from nextcloud/pimp_timestampformatter
Fixes for TimestampFormatter
2017-12-28 10:51:41 +01:00
John Molakvoæ (skjnldsv) 84c961919b
Fixed top position of multiselected files table
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-12-26 17:22:18 +01:00
John Molakvoæ (skjnldsv) c8db1ed741
Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-12-26 16:37:34 +01:00
Roeland Jago Douma 735b9fb81a
Fixup code
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-22 13:08:00 +01:00
Morris Jobke e37fa60784
Merge pull request #7591 from nextcloud/trigger-events-before-and-after-a-file-action-is-executed
Trigger events before and after a file action is executed
2017-12-22 12:31:55 +01:00
Roeland Jago Douma e40d6f6d8c
Merge pull request #7597 from nextcloud/fix-anchor-change-when-clicking-on-sharing-page-menu
Fix anchor change when clicking on sharing page menu
2017-12-22 12:28:27 +01:00
Roeland Jago Douma 1477b971b2
Merge pull request #7605 from nextcloud/wait-for-the-shared-link-to-be-set-in-the-acceptance-tests
Wait for the shared link to be set in the acceptance tests
2017-12-22 10:35:27 +01:00
Daniel Calviño Sánchez e24a1c51e8 Wait for the shared link to be set in the acceptance tests
When clicking on "Share link" in the "Sharing" tab of the Files app an
input field with the link appears. That input field already exists in
the DOM, although empty, before clicking on "Share link", and when that
is done the proper value is set and then the input field is shown.

In the acceptance tests "getValue()" can return the value of hidden
elements too, so as long as an element exists its value is returned
without waiting for the field to be visible. Due to this if the test
code runs too fast the "I write down the shared link" step could be
executed before the proper value was set, so the shared link got in that
case would be an empty value, and this would lead to failures when the
following steps were executed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-22 09:13:47 +01:00
Daniel Calviño Sánchez 8916735dd3 Add missing timeout multiplier
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-22 09:13:47 +01:00
John Molakvoæ d0e7b0d8c3
Merge pull request #7478 from nextcloud/breadcrumbs-buttons-fixes-gallery
Fixed breadcrumbs calculation and actions flow
2017-12-22 09:11:16 +01:00
Daniel Calviño Sánchez 37238725d6 Fix typo in callback name
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-22 08:57:50 +01:00
John Molakvoæ (skjnldsv) 8cc90ab4de
Fixed breadcrumbs tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-12-21 16:22:54 +01:00
Daniel Calviño Sánchez eb256b3ed5 Fix anchor change when clicking on sharing page menu
The share menu toggle and some share menu items included an 'href="#"'
attribute, so they were handled as internal links by the browser, which
changed the current anchor when they were clicked. However, there was no
real need to change the anchor in those cases, and it could interfere
with other apps (for example, the PDF viewer sets the current anchor to
"#pdfviewer" when it is shown and it hides itself when that anchor is
modified). According to the HTML 5 spec the "href" attribute is not
mandatory for "a" elements, so they were removed.

Other options would have been to change the elements from "a" to "div"
or something like that, but that would have required changes to the CSS
rules too, or to prevent the default event handling for those elements
through JavaScript, which would have been a workaround instead of the
proper solution.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-21 14:19:29 +01:00
John Molakvoæ (skjnldsv) 0cb45f681f
Update quota on file upload and deletion
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-12-21 10:48:43 +01:00
Daniel Calviño Sánchez c059fbd409 Remove internal unused property
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-21 02:08:40 +01:00
Daniel Calviño Sánchez 96ed73343e Trigger the "Details" action when clicking on an empty file row space
Clicking on an empty space in a file row causes the details view to be
shown. As it is a user initiated action on the file list now it is done
by triggering the Details action instead of directly calling
"_updateDetailsView"; the result is the same in both cases, but using
the action is more consistent (clicking on the file name triggers the
default action, and clicking on the inline actions triggers those
actions) and also makes possible to use the "beforeTriggerAction" and
"afterTriggerAction" listeners.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-21 00:36:40 +01:00
Morris Jobke 0b8a9fcaea
Merge pull request #7572 from nextcloud/fix-box-shadow
Fix box shadow of header elements
2017-12-20 13:52:53 +01:00
John Molakvoæ (skjnldsv) 3105a2780b
zindex fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-12-20 13:50:44 +01:00
Morris Jobke 0fef608927
Add the webkit sticky position prefix
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-20 13:48:09 +01:00
Morris Jobke 9e6f9564ec
Properly show action icons
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-20 13:48:09 +01:00
Marin Treselj eebc70cf1e
Make contorls stick to the top when scrolling
Signed-off-by: Marin Treselj <marin@pixelipo.com>
2017-12-20 13:48:09 +01:00
Marin Treselj 228ca16bea
Dynamic control bar width
Signed-off-by: Marin Treselj <marin@pixelipo.com>
2017-12-20 13:48:09 +01:00
John Molakvoæ (skjnldsv) 7a9e65ceed
Fixed breadcrumbs calculation and actions flow
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-12-20 13:48:09 +01:00
Morris Jobke dc8809e754
Merge pull request #7498 from nextcloud/fix_7497
Better handle avatars
2017-12-20 12:38:05 +01:00
Morris Jobke f854831045
Fix box shadow of header elements
* unify shadow blur from 3px to 10px
* remove opacity of background of app labels
* for IE: use box-shadow as fallback (because the filter: drop-shadow is not supported)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-20 11:45:21 +01:00
Julius Härtl 0ff3c81fc1
Fix failing AvatarTest
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2017-12-19 18:49:27 +01:00
Roeland Jago Douma 325637f4f3
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-19 18:49:27 +01:00
Roeland Jago Douma 328047f638
Also do callback on the failing function
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-19 18:49:26 +01:00
Julius Härtl 4c3eb80a91
Hide delete button if the avatar is a generated one
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2017-12-19 18:49:26 +01:00
Julius Härtl d497f79625
Fix fallback when image loading fails
With the new avatar endpoint there is no difference between unknown
users and errors when generating the placeholder avatar. Therefore the
avatar function will now show the old placeholder if both a user and
displayname was given as parameters.

In case there is no displayname provided we cannot build the proper
placeholder so the unknown user placeholder is shown.

The displayname is not required for the avatar anymore, so we can
get rid of the old code path for placeholders.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-19 18:49:26 +01:00
Roeland Jago Douma 6b5e3a9365
Still call callback once avatar is loaded
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-19 18:49:26 +01:00
John Molakvoæ (skjnldsv) a118817a69
Add loading icon on avatar
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-12-19 18:49:26 +01:00
Roeland Jago Douma 0f235aec1f
Update avatar on displayname change
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-19 18:49:26 +01:00
Roeland Jago Douma a4ca92f29a
Remove generated avatar on displayname change
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-19 18:49:26 +01:00
Roeland Jago Douma 6371b76598
Since we now always generate an avatar do not load the placeholder
The js and php code differ ever so slightly. So having the placeholder
for a second and then the image is just weird.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-19 18:49:25 +01:00
Daniel Calviño Sánchez 7760f16521 Trigger events before and after a file action is executed
In the same way that other elements can know when a FileAction is
registered or a default action is set this commit makes possible to be
notified before and after a FileAction is executed.

This is achieved by wrapping the registered action handler in a custom
function that notifies the listeners before and after executing the
handler itself. Due to this approach only FileActions registered through
"registerAction" trigger the events, although that is not a problem as
this is how the actions should be added to the FileActions anyway.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-19 18:33:34 +01:00
blizzz b6fcf59881
Merge pull request #7576 from nextcloud/fix_7574
Use javascript to send the actual password reset
2017-12-19 18:05:14 +01:00
Roeland Jago Douma cfd116b5f9
Merge pull request #7566 from nextcloud/fix-opening-the-menu-in-a-share-page
Fix opening the menu in a share page
2017-12-19 14:41:42 +01:00
Roeland Jago Douma cdaf99cf58
Use javascript to send the actual password reset
Fixes #7574

During some refactoring the event linked to password reset got removed.
This ment that we just submitted a normal POST but without the CSRF
token. And none of the js magic to redirect afterwards.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-19 14:00:47 +01:00
Roeland Jago Douma e550a3ddd8
Merge pull request #7562 from nextcloud/fix-wrongly-cached-result
Cache final result of update check
2017-12-19 10:12:33 +01:00
Daniel Calviño Sánchez 48b62a0eee Fix opening the menu in a Share page
".popovermenu" elements are visible or not depending on whether they
also have the "open" CSS class or not. "#header .menu" elements were
always hidden, so when both rules applied to the same element, like in
the menu of a Share page, the element was always hidden due to
"#header .menu" being more specific than ".popovermenu" and thus
overriding its rules. Now, "#header .menu" elements are hidden only if
they are not a ".popovermenu" too.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-19 06:58:58 +01:00
Daniel Calviño Sánchez 2ec181e084 Add acceptance test for opening the menu in a public shared link
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-19 06:55:47 +01:00
Morris Jobke b01d20c0d7
Merge pull request #7556 from nextcloud/smb-stat-exception
handle exceptions in SMB::stat
2017-12-18 22:31:05 +01:00
Roeland Jago Douma e294323df2
Merge pull request #7517 from nextcloud/add-index-to-share-table
Add index to share_with column in the share table
2017-12-18 22:23:53 +01:00
Roeland Jago Douma a84d11de7b
Merge pull request #7531 from nextcloud/ldap/createdistributed
don't use deprecated method for requesting memcache
2017-12-18 22:08:32 +01:00