Commit Graph

54166 Commits

Author SHA1 Message Date
Robin Appelman e357d46863
filter files containing a hash in the path for ftp storages
the php ftp streamwrapper doesn't handle hashes correctly and will break when it tries to enter a path containing a hash.

By filtering out paths containing a hash we can at least stop the external storage from breaking completely

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-10 14:18:40 +02:00
Morris Jobke 18acb137d3
Merge pull request #21733 from nextcloud/fix/noid/cache-system-card-etag-during-request
Update system addressbook card only when there was a change based on a cached etag
2020-07-09 13:59:24 +02:00
Joas Schilling 183e2efd95
Merge pull request #21489 from nextcloud/fix/share/use_correct_mount
Use the correct mountpoint to calculate
2020-07-09 12:57:37 +02:00
Joas Schilling 71a62670cd
Merge pull request #21736 from nextcloud/bugfix/21433
Fix placeholder issues with multiplace spaces in the name
2020-07-09 12:55:34 +02:00
Morris Jobke aab646a9d0
Update system addressbook card only when there was a change based on a cached etag
Due to our old and new hook system the card dav backend listens to old and new hooks. This triggers this code multiple times and always causes an update. With this change we cache the etag during a request and only trigger the update if the etag has changed. This does not catches all not needed updates, but it does not need another round trip to the database and still covers most cases where multiple attributes are updated during one single request.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-09 11:43:58 +02:00
Robin Appelman 118965ad98
better cleanup in share tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-09 11:14:45 +02:00
Robin Appelman 70906a359f
ensure home storage is initialized on first setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-09 11:14:45 +02:00
Robin Appelman 37c334a2a6
ensure mounts are scanned during tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-09 11:14:44 +02:00
Daniel Calviño Sánchez e0fbf4d033
Add more integration tests for resharing permissions
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-07-09 11:14:44 +02:00
Roeland Jago Douma 43efac345e
Use the correct mountpoint to calculate
If we use the owners mount point this results in null. And then the rest
of the checks get called with null. Which doesn't work.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-09 11:14:44 +02:00
Morris Jobke 8f4d5334f4
Merge pull request #21767 from nextcloud/enh/lazy_register_navigation
Lazy register the navigation
2020-07-09 10:52:19 +02:00
Roeland Jago Douma 1cf3280c8e
Lazy register the navigation
This makes sure that we do not translate unneeded strings on for example
webdav requests.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-09 10:12:53 +02:00
Morris Jobke b2c6e219a2
Merge pull request #21746 from nextcloud/techdebt/noid/cloud_federation_api-bootstrap
Move cloud_federation_api to bootstrap mechanism
2020-07-09 10:00:56 +02:00
Morris Jobke 766cadc253
Merge pull request #21766 from nextcloud/fix/21761/regression-in-return-value
Fix regression in return value of OC_Util::checkDataDirectoryPermissi…
2020-07-09 10:00:23 +02:00
Morris Jobke 9e88456768
Fix regression in return value of OC_Util::checkDataDirectoryPermissions due to #21761
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-09 09:29:44 +02:00
Julius Härtl 00d545f87e Fix placeholder issues with multiplace spaces in the name
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-07-09 07:05:15 +00:00
Roeland Jago Douma f3768e2a2a
Merge pull request #21761 from nextcloud/fix/permission_check_translation
Kill another unneeded translation
2020-07-09 08:28:57 +02:00
Nextcloud bot 5864501d3f
[tx-robot] updated from transifex 2020-07-09 02:17:35 +00:00
Roeland Jago Douma c7d9636e82
Kill another unneeded translation
We should only translate things when we actually need them.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-08 21:47:16 +02:00
Roeland Jago Douma ce5cb5ac33
Merge pull request #21758 from nextcloud/fix/routes/defaults
Fix supporting defaults for routes
2020-07-08 20:42:28 +02:00
Roeland Jago Douma 3f447b9c8c
Fix supporting defaults for routes
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-08 19:52:45 +02:00
Roeland Jago Douma 44f8312cd3
Merge pull request #21754 from nextcloud/td/no_translation_on_each_request
Only translate if we need the string
2020-07-08 19:08:34 +02:00
Roeland Jago Douma 76eb793f9b
Only translate if we need the string
This translation was done in each call. Over and over and over again.
All while it was probably not used in 99.99999% of the cases. A small
gain. But still.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-08 15:12:01 +02:00
Roeland Jago Douma 32927fd470
Merge pull request #21729 from nextcloud/enh/noid/orphaned-mounts
Add removal of mounts without storages to files:cleanup command
2020-07-08 14:17:54 +02:00
Roeland Jago Douma 4a426239a2
Merge pull request #21745 from nextcloud/techdebt/noid/lookup_server_connector-bootstrap
Move lookup server connector to bootstrap mechanism
2020-07-08 14:16:08 +02:00
Morris Jobke e76c178b75
Merge pull request #21749 from nextcloud/techdebt/noid/contactsinteraction-bootstrap
Move contactsinteraction and comments to bootstrap mechanism
2020-07-08 13:03:00 +02:00
Morris Jobke a5488c01de
Move contactsinteraction to bootstrap mechanism
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-08 12:23:59 +02:00
Julius Härtl c06e69c9dd
Test for proper removal of mount entries
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-08 09:54:26 +02:00
Morris Jobke a6d308ff80
Move cloud_federation_api to bootstrap mechanism
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-08 09:53:05 +02:00
Morris Jobke 1a219ca5e8
Move lookup server connector to bootstrap mechanism
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-08 09:42:30 +02:00
Roeland Jago Douma 7a92113fec
Merge pull request #21643 from nextcloud/enh/no_routeactionhadler_inits
Do not create a RouteActionHandler object for each route
2020-07-08 09:28:05 +02:00
Morris Jobke 54d36c047b
Merge pull request #21741 from nextcloud/debt/noid/url-generator-does-not-implement-i-user-session
Fix type for $urlGenerator
2020-07-08 09:06:56 +02:00
Daniel Kesselberg ba0ef74c06
Fix type for $urlGenerator
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-07-08 09:06:29 +02:00
Morris Jobke abe222c979
Merge pull request #21739 from nextcloud/techdebt/14552/migrate-OC-initSession
Remove hook for initSession
2020-07-08 09:02:37 +02:00
Nextcloud bot 8ca1208bbb
[tx-robot] updated from transifex 2020-07-08 02:16:58 +00:00
Morris Jobke 8d2d051841
Remove hook for initSession
It's not used anyways and allowed to manipulate the state of the session. Also removed the code handling this.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-07 21:44:36 +02:00
Julius Härtl 479aa975d3
Add removal of mounts without storages to files:cleanup command
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-07 12:36:59 +02:00
Roeland Jago Douma edc1c77dd9
Do not create a RouteActionHandler object for each route
This is not required and doesn't allow us to be properly lazy. On top of
it this doesnt allow us to cache the routes (since closures/objects
can't be cached).

This is the first small step into cleaning up the routing we have

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-07 12:33:22 +02:00
Morris Jobke cd7a6276f2
Merge pull request #21676 from J0WI/fix-chmod-on-fd
Fix chmod on file descriptor
2020-07-07 09:44:57 +02:00
Morris Jobke 23c4bc29a4
Merge pull request #21725 from nextcloud/bugfix/21316/ie11-quoted-props
Fix main bundle on IE11
2020-07-07 09:43:34 +02:00
Julius Härtl 6a67f84163
Bump bundles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-07 09:23:32 +02:00
Julius Härtl 5aef97cfa7
Do not quote properties when optimizing bundles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-07 09:23:32 +02:00
Nextcloud bot 09b9f94c38
[tx-robot] updated from transifex 2020-07-07 02:16:31 +00:00
Morris Jobke 6c6f41ca69
Merge pull request #21460 from nextcloud/enhancement/systemtags-bootstrap
Move systemtags to the new bootstrap mechanism
2020-07-06 23:06:10 +02:00
Morris Jobke 7ad0381e5c
Merge pull request #21639 from nextcloud/techdebt/noid/move-away-from-database-xml
Move away from database xml
2020-07-06 22:42:39 +02:00
Morris Jobke 560c485e5d
Merge pull request #21714 from nextcloud/td/remove/getAppFolder
Remove old deprecated getAppFolder
2020-07-06 22:36:55 +02:00
Morris Jobke 2124d1914a
Merge pull request #18867 from HolgerHees/patch-1
Update SecurityMiddleware.php
2020-07-06 22:31:48 +02:00
Roeland Jago Douma 7d128ebf3e
Remove old deprecated getAppFolder
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-06 22:06:58 +02:00
Holger Hees e70249e089
Update SecurityMiddleware.php
OC::$WEBROOT can be empty in case if your nextcloud installation has no url prefix. This will result in an empty Location Header.

in other areas OC::$WEBROOT is always used together with an /
2020-07-06 21:34:46 +02:00
Morris Jobke b2959d7c86
Merge pull request #21717 from nextcloud/fix/tests/sharebymail
Fix sharebymail tests
2020-07-06 21:33:19 +02:00