Commit Graph

54166 Commits

Author SHA1 Message Date
Joas Schilling 33f6a26a7d
Merge pull request #21091 from nextcloud/sftp-normalize-path
normalize sftp path in read and write stream
2020-06-03 12:17:38 +02:00
Christoph Wurst 111c8c9e0e
Merge pull request #21181 from nextcloud/fix/remote-share-remove-error-handling
Do not only catch Exceptions but any Throwable during rmt share delete
2020-06-03 11:11:47 +02:00
Julius Härtl 81de9e8e94
Only use background fade if nextcloud blue is set
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-06-03 09:17:15 +02:00
Nextcloud bot f62f23ed1d
[tx-robot] updated from transifex 2020-06-03 02:16:18 +00:00
Roeland Jago Douma 7d33de5599
Merge pull request #21190 from nextcloud/td/js/linter
Fix some linter warning
2020-06-02 16:02:07 +02:00
Roeland Jago Douma 3bca70999a
Fix some linter warning
Part of my ongoing battle against deprecation messages.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-06-02 14:24:55 +02:00
dependabot-preview[bot] e0a47ac6fe Bump vue-router from 3.2.0 to 3.3.2
Bumps [vue-router](https://github.com/vuejs/vue-router) from 3.2.0 to 3.3.2.
- [Release notes](https://github.com/vuejs/vue-router/releases)
- [Changelog](https://github.com/vuejs/vue-router/blob/dev/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-router/compare/v3.2.0...v3.3.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-06-02 11:49:45 +00:00
Roeland Jago Douma 1c7d089434
Merge pull request #21164 from nextcloud/dependabot/npm_and_yarn/nextcloud/dialogs-1.3.1
Bump @nextcloud/dialogs from 1.3.0 to 1.3.1
2020-06-02 13:34:48 +02:00
Christoph Wurst 09a632242d
Do not only catch Exceptions but any Throwable during rmt share delete
When a remote share is deleted, we notify the remove instance. This may
trigger various error conditions, which we want to catch in order to
avoid undeletable shares. The try-catch, however, did only capture
exceptions, so things like TypeErrors were not caught and caused the
process to fail hard.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-02 09:21:09 +02:00
Nextcloud bot 796b454021
[tx-robot] updated from transifex 2020-06-02 02:16:02 +00:00
Daniel Calviño Sánchez fdac2ffe24 Restore previous state when failing to change video verification state
When video verification can not be enabled or disabled the previous
state is set again in the JavaScript share object. This ensures that the
UI will not reflect a misleading state.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-06-01 18:50:13 +02:00
Christoph Wurst 5d92a6a7c9 Fix the Talk verification
When enabling or disabling Talk verification in mail shares the server
expects also a new password to be set. As we always just update one
property at a time this means the Talk verification was impossible to
activate or deactivate. With this patch, we send the talk option AND the
new password. If there is no new password, the Talk option is disabled
(in mail shares; in link shares it is possible to enable or disable the
video verification without changing the password).

When we finally have descriptive text on ActionCheckbox'es we should
definitely add some explanatory text for the user. Right now this is as
good as it gets.

We'll have to backport to 18.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-01 17:21:42 +02:00
Nextcloud bot 0f4de3d353
[tx-robot] updated from transifex 2020-06-01 02:16:00 +00:00
dependabot-preview[bot] c4a7d45b70 Bump @nextcloud/dialogs from 1.3.0 to 1.3.1
Bumps [@nextcloud/dialogs](https://github.com/nextcloud/nextcloud-dialogs) from 1.3.0 to 1.3.1.
- [Release notes](https://github.com/nextcloud/nextcloud-dialogs/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-dialogs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-dialogs/compare/v1.3.0...v1.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-31 11:12:07 +00:00
Nextcloud bot a1bb18a837
[tx-robot] updated from transifex 2020-05-31 02:16:19 +00:00
dependabot-preview[bot] 903b2e46a5
Bump @babel/core from 7.9.6 to 7.10.2
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.9.6 to 7.10.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.10.2/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-31 01:19:06 +00:00
Roeland Jago Douma 43a0bf7215
Merge pull request #21155 from nextcloud/td/move_to_capabilities_package
Move to @nextcloud/capabilities package
2020-05-30 08:58:19 +02:00
Nextcloud bot 64c15a15d4
[tx-robot] updated from transifex 2020-05-30 02:16:04 +00:00
Morris Jobke 395cd140b1
Merge pull request #21154 from nextcloud/fix/file_info_load_order
Fix the loading order of the js files_info and files_client
2020-05-29 21:32:15 +02:00
Morris Jobke 8a54586bbe
Merge pull request #21156 from nextcloud/do-not-clone-the-whole-talk-repository-for-integration-tests
Do not clone the whole Talk repository for integration tests
2020-05-29 21:31:35 +02:00
Daniel Calviño Sánchez f5ef3ee352 Do not clone the whole Talk repository for integration tests
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 17:02:03 +02:00
Roeland Jago Douma 7157134454
Merge pull request #21141 from nextcloud/fix/require-ext-pdo-composer
List ext-pdo as hard requirement for composer
2020-05-29 16:39:59 +02:00
Roeland Jago Douma 0209532638
Move to @nextcloud/capabilities package
And kill of oc_capabilities and _oc_capabilities globals

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-29 16:10:08 +02:00
Roeland Jago Douma 71b2f94101
Fix the loading order of the js files_info and files_client
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-29 15:43:45 +02:00
Roeland Jago Douma 532f4c41da
Merge pull request #20970 from nextcloud/td/js/escape-html-global
Remove the escape-html global
2020-05-29 13:36:55 +02:00
Roeland Jago Douma 251a4d3097
Merge pull request #21143 from nextcloud/fix-password-changes-in-link-and-mail-shares
Fix password changes in link and mail shares
2020-05-29 13:36:09 +02:00
Roeland Jago Douma b9e7fd2418 Remove the escape-html global
Already announced for 19 that it would go. So now it realy does go.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-29 08:34:10 +00:00
Roeland Jago Douma efd025cbc3
Merge pull request #21118 from nextcloud/td/move_systemtags
Move systemtags to a proper location
2020-05-29 09:14:25 +02:00
Roeland Jago Douma ca606cea5c
Merge pull request #21146 from nextcloud/fix-reference-to-wrong-class-name
Fix reference to wrong class name
2020-05-29 08:46:23 +02:00
Nextcloud bot ebd387e89a
[tx-robot] updated from transifex 2020-05-29 02:16:30 +00:00
Daniel Calviño Sánchez b192c04dc2 Add integration tests for video verification
Enabling the "send password by Talk" property of shares require that
Talk is installed and enabled, so the Drone step that runs them has to
first clone the Talk repository.

When the integration tests are run on a local development instance,
however, it is not guaranteed that Talk is installed. Due to this the
"@Talk" tag was added, which ensures that any feature or scenario marked
with it will first check if Talk is installed and, if not, skip the
scenario (instead of failing).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:50:30 +02:00
Daniel Calviño Sánchez a2f80d4f4c Add integration tests for creating and updating a mail share
In most cases, when a mail share is created or updated an e-mail is sent
to the sharee, which is done by connecting to the SMTP server set in the
configuration. If the server can not be contacted then the creation or
update of the mail share fails.

To make possible to test mail shares without using a real SMTP server a
fake one has been added. The original script, which is MIT licensed, was
based on inetd, so it was slightly modified to run on its own.

In order to use it from the integration tests the "Given dummy mail
server is listening" step has to be called in the scenarios in which the
mail server is needed.

For now that is the only available step; things like checking the sent
mails, while possible (as the script can log the mails to certain file),
have not been added yet.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:50:29 +02:00
Daniel Calviño Sánchez 7817f8578b Generalize integration test steps to download last share
Note that the "last link share can be downloaded" step was kept as it
tests the "url" property specific of link shares.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:46:12 +02:00
Daniel Calviño Sánchez 6e49d3bb94 Remove unused variables
The step names were adjusted accordingly.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:46:12 +02:00
Daniel Calviño Sánchez 45de42a6b8 Fix disabling send password by Talk without new password in mail shares
When "send password by Talk" was disabled in a mail share it was
possible to keep the same password as before, as it does not pose any
security issue (unlike keeping it when "send password by Talk" is
enabled, as in that case the password was already disclosed by mail).

However, if a mail share is updated but the password is not set again
only the hashed password will be available. In that case it would not
make sense to send the password by mail, so now the password must be
changed when disabling "send password by Talk".

Note that, even if explicitly setting the same password again along with
the "send password by Talk" property would work, this was also prevented
for simplicity.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:46:12 +02:00
Daniel Calviño Sánchez 37f231333f Fix reference to wrong class name
\OCP\IShare does not exist; the right name is \OCP\Share\IShare,
although it is already imported as IShare.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 01:41:06 +02:00
Morris Jobke 077c1a9b9f
Merge pull request #21140 from nextcloud/enhancement/oc-get-all-apps-return-type-doc
Document \OC_App::getAllApps return type
2020-05-28 22:37:35 +02:00
Daniel Calviño Sánchez a426f84dbe Fix enabling send password by Talk with same password in mail shares
When "send password by Talk" is enabled in a mail share a new password
must be also set. However, when the passwords of the original and the
new share were compared it was not taken into account that the original
password is now hashed, while the new one is not (unless no new password
was sent, in which case the password of the original share was set in
the new share by the controller, but that was already prevented due to
both passwords being literally the same), so it was possible to set the
same password again.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-28 21:51:28 +02:00
Daniel Calviño Sánchez 7569590514 Fix enabling send password by Talk with empty password in link shares
When "send password by Talk" is enabled in a link share now a non empty
password is enforced.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-28 21:51:28 +02:00
Daniel Calviño Sánchez e59e283cc2 Fix creating a mail share with a password
When a mail share was created with a password the given password was not
hashed, so it was not possible to open the share with that password.
Moreover, if passwords were enforced the given password was ignored and
a new one was set (although in this case it was hashed so it worked as
expected). Now the given password is properly hashed and not overriden.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-28 21:51:22 +02:00
Daniel Calviño Sánchez a2b0a7c30e Extend mail shares unit tests to check the password and mail template
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-28 21:50:08 +02:00
Roeland Jago Douma 28f8a445e4 Move the systemtags to core/src
* Move to the handlebar loader from webpack

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-28 19:05:09 +00:00
Christoph Wurst adf7d17cb2
List ext-pdo as hard requirement for composer
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-05-28 20:43:50 +02:00
Christoph Wurst 97e9823787
Document \OC_App::getAllApps return type
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-05-28 20:37:24 +02:00
Roeland Jago Douma b638c6ee09
Merge pull request #20597 from nextcloud/enh/lazy_node_events
Add lazy events for the Node API
2020-05-28 14:15:59 +02:00
Roeland Jago Douma 77c1aeb84e
Merge pull request #21124 from nextcloud/feature/20612/add-capability-for-file-comments
Add a capability when file comments are enabled
2020-05-28 14:13:48 +02:00
Joas Schilling ff381dda08
Add a capability when file comments are enabled
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-05-28 12:43:53 +02:00
Roeland Jago Douma 6aa6ab3e02
Add lazy events for the Node API
Right now if you want to get events via the Node API you have to have a
real instance of the Root. Which in turns sets up the whole FS.

We should make sure this is done lazy. Else enabling the preview
generator for example makes you setup the whole FS on each and every
authenticated call.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-28 12:35:45 +02:00
Nextcloud bot 1d469fc06e
[tx-robot] updated from transifex 2020-05-28 02:16:38 +00:00
Roeland Jago Douma 3ee2dbeff9
Merge pull request #21122 from nextcloud/enhancement/auth-token-exception-reporting
Improve traces of invalid token exceptions
2020-05-27 19:37:22 +02:00