e2453d78c0
Properly catch whether a share is `null`
...
Despite it's PHPDoc the function might return `null` which was not properly catched and thus in some situations the share was resolved to the sharing users root directory.
To test this perform the following steps:
* Share file in owncloud 7 (7.0.4.2)
* Delete the parent folder of the shared file
* The share stays is in the DB and the share via the sharelink is inaccessible. (which is good)
* Upgrade to owncloud 8 (8.0.2) (This step is crucial. The bug is not reproduceable without upgrading from 7 to 8. It seems like the old tokens are handled different than the newer ones)
* Optional Step: Logout, Reset Browser Session, etc.
* Access the share via the old share url: almost empty page, but there is a dowload button which adds a "/download" to the URL.
* Upon clicking, a download.zip is downloaded which contains EVERYTHING from the owncloud directory (of the user who shared the file)
* No exception is thrown and no error is logged.
This will add a check whether the share is a valid one and also adds unit tests to prevent further regressions in the future. Needs to be backported to ownCloud 8.
Adding a proper clean-up of the orphaned shares is out-of-scope and would probably require some kind of FK or so.
Fixes https://github.com/owncloud/core/issues/15097
2015-03-24 11:21:58 +01:00
9cb07f126d
[tx-robot] updated from transifex
2015-03-24 01:55:24 -04:00
8906158d3b
Merge pull request #15123 from owncloud/fix_14098
...
offset needs to be considered in computed limit
2015-03-23 17:50:24 +01:00
02c0fe8d43
Merge pull request #13941 from owncloud/fix-folder-upload-on-firefox
...
Show message if upload of folder isn't allowed
2015-03-23 17:18:46 +01:00
7520d0fb3d
offset needs to be considered in computed limit
2015-03-23 16:51:40 +01:00
7f2b06dfa0
Merge pull request #15120 from owncloud/ldap-occ-fix-warnings
...
fix PHP warnings when using occ with some LDAP commands
2015-03-23 16:29:27 +01:00
468fc675a4
fix PHP warnings when using occ with some LDAP commands
2015-03-23 15:19:41 +01:00
1a26263123
Do not walk over the users directory, but over the list of tagged objects
...
Way quicker
2015-03-23 15:10:58 +01:00
0e4ba618cf
Merge pull request #14383 from jknockaert/newbranch
...
make encryption stream wrapper seekable
2015-03-23 09:22:36 -04:00
a9b4f0d842
[tx-robot] updated from transifex
2015-03-23 01:54:48 -04:00
a79d973005
[tx-robot] updated from transifex
2015-03-22 01:55:21 -04:00
bdde2156da
Added extra unit test
2015-03-21 09:47:07 +01:00
9ce8e1ddc7
OCS API should return fancy OC url
...
* Also use the URLGenerator
2015-03-21 09:47:06 +01:00
e36a33c89a
[tx-robot] updated from transifex
2015-03-21 01:56:09 -04:00
afa8872955
Merge pull request #14857 from owncloud/preview-provider-registration-in-manager
...
Preview provider registration in manager
2015-03-20 16:34:22 +01:00
e44ab2dcfe
Merge pull request #11884 from owncloud/ext-appframework
...
Cleanup ext storage CRUD code, introduce storage config id
2015-03-20 14:17:32 +01:00
67160e0861
Do not automatically add "update" permission to shared mounts
...
In the past it seems the update permission was needed to be able to
rename shared mounts, but it doesn't seem to be the case any more.
Removing the "update" permission that used to be added automatically
fixes the read-only permission check when trying to overwrite a
read-only file over WebDAV.
2015-03-20 12:33:59 +01:00
eef5851a67
Fix share permission related unit tests
2015-03-20 11:30:51 +01:00
c37913b1d5
Introduce async status checking
2015-03-20 09:48:14 +00:00
7776e088d6
Group sharing activities by user/group and file respectively
2015-03-20 09:49:33 +01:00
e8680e6637
[tx-robot] updated from transifex
2015-03-20 01:55:23 -04:00
5f7b3a4dbe
Rename must be possible with update-only permission
...
and this as long as the rename is done within the same folder.
2015-03-19 21:55:56 +01:00
c57fb62029
Merge pull request #14946 from owncloud/dropbox-root-fix
...
Fix root request path for Dropbox
2015-03-19 17:19:57 +01:00
857b22c61b
Merge pull request #15025 from rullzer/ocs_respect_enforced_date
...
Ocs respect enforced date
2015-03-19 17:06:04 +01:00
be6edd465a
Merge pull request #14537 from owncloud/oci-external-share
...
Fix external shares without password on oracle
2015-03-19 16:20:12 +01:00
dd3307dd19
Added unit test
...
Tests added to make sure that removing an expire date when this is
enforced is not allowed.
2015-03-19 10:47:09 +01:00
e40b0701d7
[tx-robot] updated from transifex
2015-03-19 01:55:06 -04:00
a9e6eba018
Reenable trashbin after failed rename
...
After a failed rename, the post_rename hook is not called.
This quickfix makes sure the trashbin storage logic is reenabled
also after a failed rename.
2015-03-18 19:56:31 +01:00
c2315aa015
Fix shared storage permission checks
2015-03-18 19:56:31 +01:00
e5fd6816df
fix position of 'Deleted files' sidebar entry, fix #10815
2015-03-18 13:31:16 +01:00
8a95bf18b7
[tx-robot] updated from transifex
2015-03-18 01:55:22 -04:00
760f5fc5e5
Merge pull request #14954 from owncloud/cache-image-path
...
Cache \OC\URLGenerator::imagePath
2015-03-17 19:36:23 +00:00
8ebb198ef3
Add a unit test for the naming conflict on the mountpoint name
2015-03-17 16:55:03 +01:00
ce89f12566
add whitespace to prevent file deletion when wanting to scroll
2015-03-17 16:54:42 +01:00
ba3e4ede39
Use insertIfNotExists() instead of manual logic
2015-03-17 16:03:24 +01:00
05c4848954
Correctly get the unique mountpoint name when mounting the share
...
Previously the mount name was checked for uniqueness prior to inserting the
share. This caused problems, when two shares with the same name where done
or folder, mount point, local share with the same name was done, between
sending and accepting of the remote share
2015-03-17 16:03:24 +01:00
9e2ebf2dce
Cache \OC\URLGenerator::imagePath
...
\OC\URLGenerator::imagePath is a really expensive operation due to all the I/O handling and can really benefit from caching.
2015-03-17 12:35:47 +01:00
9c45ab49a1
Use a closure for the files app entry and deprecate old methods
2015-03-17 12:17:09 +01:00
e5e30924b1
Fix PHPDoc in files_external, add missing tag
...
Fix various PHPDoc issues in external storage app.
Added missing NoAdminRequired tag
2015-03-17 11:42:52 +01:00
5b6ecb2d98
Fix root request path for Dropbox
2015-03-17 10:56:24 +01:00
db033e4e19
Fix PHPDoc and Co.
...
Ref https://github.com/owncloud/core/pull/14929#discussion_r26501240
2015-03-17 10:37:09 +01:00
6525911439
Merge pull request #14929 from owncloud/s2s-scanner-warnings
...
Fix scanFile signature warnings
2015-03-17 09:51:45 +01:00
b51b4f0a2c
[tx-robot] updated from transifex
2015-03-17 01:55:43 -04:00
669ff45625
Merge pull request #14877 from owncloud/smb-constructor-noconnect
...
Wait with getting the timezone from the smb server until we need it
2015-03-16 17:01:49 +01:00
b9d9405135
Fix scanFile signature warnings
2015-03-16 16:45:11 +01:00
847880803e
Fix storage priority in JS unit test
2015-03-16 15:07:38 +01:00
06448170cf
Fix PHPDoc for StoragesController
2015-03-16 14:39:48 +01:00
3052b9571e
Fix controller test
2015-03-16 12:45:18 +01:00
47af533183
Move mimetype check from template to controller
2015-03-16 12:45:18 +01:00
4c4c0fa120
Use the PreviewManager where possible
2015-03-16 12:44:10 +01:00
72632ad402
Generate storage config ids when missing
...
When reading in old mount.json files, they do not contain config ids.
Since these are needed to be able to use the UI and the new service
classes, these will be generated automatically.
The config grouping is based on a config hash.
2015-03-16 12:18:01 +01:00
1e0d8f1774
Merge pull request #14133 from rullzer/fix_10600
...
Always display max upload size in admin panel
2015-03-16 10:05:57 +01:00
bbaf97ca43
Merge pull request #14644 from owncloud/trash-expire-command
...
Expire files from the trash in the background
2015-03-16 10:04:05 +01:00
b159c7f274
Merge pull request #14848 from owncloud/kill-curl-fallback-master
...
drop any fallback code related to curl
2015-03-16 09:56:31 +01:00
c1a3394f48
[tx-robot] updated from transifex
2015-03-16 01:55:15 -04:00
84b6ca9b81
[tx-robot] updated from transifex
2015-03-15 01:54:38 -04:00
8c5be2bc48
[tx-robot] updated from transifex
2015-03-14 01:54:45 -04:00
fb4cf53253
Fix mount config unit tests
...
Fix expected result now that it returns the status.
Added isset for some properties that are not always present.
2015-03-13 17:43:38 +01:00
3159af1983
Wait with getting the timezone from the smb server until we need it
2015-03-13 14:36:34 +01:00
34c8b1ac77
Mount options for ext storage are now passed around
...
The mount options are now passed to the UI and stored in a hidden field.
The ext storage controllers and services also know how to load/save them
from the legacy config.
2015-03-13 12:49:11 +01:00
f28f7754ae
support paged results against 389ds.
2015-03-12 22:47:20 +01:00
5855108e9b
drop any fallback code related to curl - refs https://github.com/owncloud/core/pull/14838#issuecomment-78586447
2015-03-12 21:43:41 +01:00
680ec056dc
Implement priority on client side in hidden input
2015-03-12 18:51:02 +01:00
ce94a998dd
Use storage id + appframework for ext storage CRUD
...
- Added StorageConfig class to replace ugly arrays
- Implemented StorageService and StorageController for Global and User
storages
- Async status checking for storages (from Xenopathic)
- Auto-generate id for external storage configs (not the same as
storage_id)
- Refactor JS classes for external storage settings, this mostly
moves/encapsulated existing global event handlers into the
MountConfigListView class.
- Added some JS unit tests for the external storage UI
2015-03-12 18:51:02 +01:00
5054b8e4aa
Merge pull request #14785 from owncloud/issue/14733-active-class-missing-for-admin-navigation-entry
...
Do not overwrite the active menu entry of the navigation
2015-03-12 10:45:03 +01:00
454a2563bc
[tx-robot] updated from transifex
2015-03-12 01:55:59 -04:00
cf25e6f569
Merge pull request #14773 from owncloud/allow-iframes-from-self-in-share-view
...
Allow iframes from same domain in share view
2015-03-11 15:13:59 +01:00
0f3e36fdfd
Adding a more meaningful message for sabre dav exception - fixes #14516
2015-03-11 11:53:31 +01:00
6a677ce8fe
Do not make setupMounts() public just because of testing
2015-03-11 11:10:43 +01:00
981c60f5f5
Do not overwrite the active menu entry of the navigation
2015-03-11 09:27:28 +01:00
01ea056ac8
[tx-robot] updated from transifex
2015-03-11 01:55:38 -04:00
1757d01604
Merge pull request #14640 from owncloud/rescanversionsonlyonce
...
Only rescan versions once in trashbin
2015-03-11 00:54:20 +01:00
4ffca58bc4
don't rely on \OCP\User::getUser() - it is not set properly in case of async operations
2015-03-10 11:47:52 +01:00
7cb6811a7b
tearDown the filesystem right before setting it up again
2015-03-10 11:47:06 +01:00
6dc59019af
Merge pull request #14346 from owncloud/storage-based-path-validation
...
adding storage specific filename verification
2015-03-10 11:02:47 +01:00
dcd2d7aff5
Add unit tests for external share mananger
2015-03-10 10:17:53 +01:00
48243a2949
Allow iframes from same domain in share view
...
This is required because the PDF Viewer itself is embedded using an iframe from the same domain. The default policy is blocking this.
Going on further, we have to come up with a solution in the future how to handle previews by applications, one example might be that they call their own endpoint and not the generic share page to allow applications to have full control over how to display previews.
Anyways, to test this behaviour use a decent newer browser (such as Chrome 41) and share a PDF file, obviously the PDF viewer needs to be enabled as well. Without this patch publicly shared PDF files should not get previewed and an error is thrown. (if it isn't then your browser is probably not obeying our Content-Security-Policy and you might consider switching to another one ;))
2015-03-10 10:06:15 +01:00
e069d9d3f9
[tx-robot] updated from transifex
2015-03-10 01:55:39 -04:00
94b7fa17c5
Merge pull request #14720 from owncloud/fix-shareetagpropagation
...
Fix size propagation over shared storage boundary
2015-03-09 16:24:06 +01:00
ec19d9c267
Add unit test for size propagation across share boundaries
2015-03-09 12:56:22 +01:00
abacfd84da
fixing js unit tests
2015-03-09 10:38:38 +01:00
4bac595068
adding storage specific filename verification - refs #13640
2015-03-09 10:38:37 +01:00
348fe105b1
Merge pull request #14706 from owncloud/ldap-reset-paged-search-on-null-limit
...
LDAP: set up paged search even if limit is 0
2015-03-09 08:12:25 +01:00
174f8cef64
[tx-robot] updated from transifex
2015-03-09 01:54:36 -04:00
377165ae51
[tx-robot] updated from transifex
2015-03-08 01:54:36 -05:00
73c2157171
[tx-robot] updated from transifex
2015-03-07 01:54:37 -05:00
d11f040720
[tx-robot] updated from transifex
2015-03-06 01:54:52 -05:00
4322287fc3
Fix size propagation over shared storage boundary
2015-03-05 22:23:47 +01:00
42d3ed47e2
set up paged search when limit is 0
2015-03-05 13:15:21 +01:00
7e0fd8fb50
[tx-robot] updated from transifex
2015-03-05 01:56:35 -05:00
cffc256479
Merge pull request #14672 from Crote/master
...
Add --show-password option to ldap:show-config
2015-03-04 20:21:14 +01:00
e56727e27b
Merge pull request #14690 from owncloud/trash-deletelink-unittest
...
Add unit test for selection overlay actions in trashbin
2015-03-04 14:50:11 +01:00
8149217371
Add --show-password option to ldap:show-config
2015-03-04 14:15:33 +01:00
3f6e7d6a43
Add unit test for selection overlay actions in trashbin
2015-03-04 13:49:19 +01:00
2831a1790c
Merge pull request #14675 from owncloud/files-external-smb-windows
...
adding a windows smb config for testing to ci
2015-03-04 12:27:59 +01:00
ed4dc4db07
Fix slash normalization error in AmazonS3Migration unit test
...
Since aa821ecc00
2015-03-04 09:22:21 +00:00
84785a6a39
[tx-robot] updated from transifex
2015-03-04 01:55:19 -05:00
d6b9b37ddb
Use dummy storages instead of real storages in files_external unit tests
...
We were using the SMB and SFTP backends, which since Icewind's new SMB library
results in an actual attempted connection just by constructing the storage.
This commit replaces all references to real storages (except when necessary)
with a dummy storage class.
2015-03-03 17:29:17 +01:00
7d3e228365
adding a windows smb config for testing
2015-03-03 17:29:10 +01:00
133c37fe22
Merge pull request #14652 from owncloud/kill-download-from-url
...
Remove "Download from URL" feature
2015-03-03 10:10:15 +01:00
Lukas Reschke
Jenkins for ownCloud
blizzz
Morris Jobke
Joas Schilling
Clark Tomlinson
Roeland Jago Douma
Thomas Müller
Vincent Petry
Robin McCorkell
Robin Appelman
Jan-Christoph Borchardt
Robin Appelman
Laurens Post