Commit Graph

6094 Commits

Author SHA1 Message Date
Morris Jobke 9ca848c317
Opening the trashbin causes errors in log for files without preview
* put a file without a generated preview in the trashbin
  (e.g. a *.docx file)
* open the trashbin
* following errors will show up in the nextcloud.log:
	- filesize(): stat failed for ...
	- fopen(...): failed to open stream: No such file or directory at ...
	- fread() expects parameter 1 to be resource, boolean given at ...
	- fclose() expects parameter 1 to be resource, boolean given at ...
	- imagecreatefromstring(): Empty string or invalid image at ...

This is because the preview code tries to load an SVG image, which
is obviously only text.

The fix simply handles this before the loading happens and the web UI
keeps showing the default mimetype icon.
2016-09-13 20:18:09 +02:00
Roeland Jago Douma 318ea301c3 Merge pull request #1379 from nextcloud/stable10-backport-711
stable10 backport: Apply password policy on user creation
2016-09-13 19:35:35 +02:00
Joas Schilling 107b418815
Fix MissingMandatoryParametersException for share notifications
The routing system is non-forgiving
2016-09-13 14:09:34 +02:00
michag86 5fc59a1515 Apply password policy on user creation 2016-09-12 22:45:46 +02:00
Bjoern Schiessle 7d183a28d2
skip shared files, if files get decrypted only for a specific user we shouldn't touch files owned by a different user. 2016-09-09 14:55:46 +02:00
Lukas Reschke 2ae08d6fc2
Match only for actual session cookie
OVH has implemented load balancing in a very questionable way where the reverse proxy actually internally adds some cookies which would trigger a security exception. To work around this, this change only checks for the session cookie.
2016-09-08 21:07:05 +02:00
Morris Jobke 520bfa872b Merge pull request #1324 from nextcloud/backport-1323-show-download-button-for-updates-atm
[stable10] Show an download button instead of the updater
2016-09-08 15:41:45 +02:00
Morris Jobke 72fed6e8b8 Merge pull request #1322 from nextcloud/backport-1225-allow-to-validate-password-policy
Allow to validate the password_policy app
2016-09-08 15:36:03 +02:00
Joas Schilling 280a452055
Change updater URL 2016-09-08 12:29:37 +02:00
Joas Schilling 69b063f4c6
Allow to validate the password_policy app 2016-09-08 09:56:48 +02:00
Joas Schilling 810f99c1c9
Correctly remove the charset from finfo mimetype 2016-09-08 09:20:34 +02:00
Morris Jobke 12d077065c
Fix updater URL 2016-09-07 19:08:34 +02:00
Joas Schilling 28b00c5bea
Correctly remove admin sections and settings 2016-09-07 14:37:48 +02:00
Joas Schilling 27f7416519
Move navigation entries without order to the end 2016-09-07 10:52:21 +02:00
Roeland Jago Douma 782c3138c9 Merge pull request #1200 from nextcloud/stable9.1-usermountcache-orphanedshare
[stable10] Prevent error with orphaned shares when updating user mount cache
2016-08-31 15:07:40 +02:00
Lukas Reschke c4bfdb3cab Merge pull request #1183 from nextcloud/backport-529-cross-vendor-up-and-downgrades
[stable10] Allow downgrades of maintenance accross vendors
2016-08-30 19:54:20 +02:00
Vincent Petry c4f303d19c
Prevent error with orphaned shares when updating user mount cache 2016-08-30 19:45:22 +02:00
Joas Schilling 061aad5fe3
Check if the file isReadable() before sending a (cached) preview 2016-08-30 10:24:01 +02:00
Joas Schilling 7d54d03e40
Allow downgrades of maintenance accross vendors 2016-08-30 10:19:40 +02:00
Thomas Müller f6ee9340c2
[stable9.1] Fix issues where some user settings cannot be loaded when the user id differs in case sensitivity - fixes #25684 (#25686) 2016-08-29 15:19:00 +02:00
Lukas Reschke 4fb2810add
Remove reading PATH_INFO from server variable
Having two code paths for this is unreliable and can lead to bugs. Also, in some cases Apache isn't setting the PATH_INFO variable when mod_rewrite is used.

Fixes https://github.com/nextcloud/server/issues/983
2016-08-27 22:16:30 +02:00
Damjan Georgievski cc8b508987
introduce NEXTCLOUD_CONFIG_DIR env variable (see #300)
nextcloud by default uses the `/config/` directory in the source/application tree for its config file(s).
with this commit that directory can be overridden by the `NEXTCLOUD_CONFIG_DIR` environment variable.

in uwsgi, you would use the option `--env "NEXTCLOUD_CONFIG_DIR=/tmp/nx-config/"`
in apache `SetENV …`
and the cli command can be run with: `NEXTCLOUD_CONFIG_DIR=/tmp/nx-config ./occ` (or just use `export` once in the
shell).

NEXTCLOUD_CONFIG_DIR can be supplied with or without the trailing slash (`/`), but in all cases `$configDir` will have
it automatically added if needed.

The other changes are several occurrences of `OC::$SERVERROOT . '/config'` to `OC::$configDir`.
2016-08-26 12:31:43 +02:00
Roeland Jago Douma a046725321
Dark autoloader magic for ThemingDefaults 2016-08-24 13:25:16 +02:00
Lukas Reschke 805fc22276 Merge pull request #1008 from nextcloud/shared-storage-non-recursive-10
[10] Fix shared storage recursive setup
2016-08-23 22:15:21 +02:00
Robin Appelman fa980af53c prevent infinite recursion while getting storage from mount 2016-08-23 13:59:01 +02:00
Lukas Reschke 1c01728514
Cache registered autoloaders
This saves more than 20ms (!) on every request, the previous problem was that `\OC_App::registerAutoloading` calls `\OC\AppFramework\App::buildAppNamespace` which parses the appinfo.xml. Since that was also called multiple times (e.g. on cloud.nextcloud.com over 200 times) that had a significant performance impact. Also on simple PROPFIND requests.

https://blackfire.io/profiles/compare/65a53e6e-7f35-4974-b559-4c81abd01c3b/graph shows the difference nicely.
2016-08-23 11:21:42 +02:00
Lukas Reschke f4bb803564 Merge pull request #1009 from nextcloud/backport-995
[stable10] Backport Workflow section + hidden empty sections #995 to stabble10
2016-08-23 11:20:13 +02:00
Arthur Schiwon ff2f5ecbf7
Backport Workflow section + hidden empty sections #995 to stabble10
add section to worklfowengine

enlist only registered sections that also have settings registered to

adjust test

Move admin settings to workflow section

fix wrong var name

Save the container with the app's namespace so we can resolve it
2016-08-22 16:37:48 +02:00
Arthur Schiwon fa29ba1fce
hide parameters of tryLogin when logging 2016-08-22 14:33:23 +02:00
Robin Appelman a1fd9d275f Allow jail wrappers to lazily initialize the source storage 2016-08-22 12:41:04 +02:00
Robin Appelman 2a2f1b9a00 Allow storage wrappers to lazily initialize the source storage 2016-08-22 12:40:16 +02:00
blizzz 379260732c Merge pull request #918 from nextcloud/stable10_891
[Stable10] [OC] Fix unmerged shares repair targetdecision
2016-08-22 12:09:27 +02:00
Julius Haertl fe15940233
Fix loading of ThemingDefaults 2016-08-19 11:29:58 +02:00
Morris Jobke f68d5d1071 Merge pull request #935 from nextcloud/stable10-add-cachebusters
[Stable10] add cachebusters
2016-08-18 15:49:44 +02:00
Lukas Reschke 95fca9abad
Add cache buster to left menu bar 2016-08-18 12:45:52 +02:00
Joas Schilling 91fbf815f9
Fix "Undefined index" when the values do not exist 2016-08-18 12:03:10 +02:00
Roeland Jago Douma 5b6b9ad1ff Merge pull request #921 from nextcloud/backport-867-notification-primary-action-always-first
[stable10] Make sure the primary action is always the first one
2016-08-18 10:39:27 +02:00
Joas Schilling 1927c28b9f Merge pull request #910 from nextcloud/stable10_864
[Stable10] Ensure the user exists before calling a method on it
2016-08-18 09:30:47 +02:00
Joas Schilling e1ec3964c8
Make sure the primary action is always the first one 2016-08-18 09:27:14 +02:00
Vincent Petry 11e9ce669a
Improve regexp to detect duplicate folders when repairing unmerged shares 2016-08-17 19:39:08 +02:00
Vincent Petry c1ad88a777
Fix unmerged shares repair with mixed group and direct shares
Whenever a group share is created after a direct share, the stime order
needs to be properly considered in the repair routine, considering that
the direct user share is appended to the $subShares array and breaking
its order.
2016-08-17 19:38:33 +02:00
Vincent Petry 837dc0b336
Improve file_target finding logic when repairing unmerged shares
Pick the most recent subshare that has no parenthesis from duplication
which should match whichever name the user picked last. If all
subshares have duplicate parenthesis names, use the least recent group
share's target instead.
2016-08-17 19:38:19 +02:00
Jörn Friedrich Dreyer 29565ec423
use $userId instead of $user 2016-08-17 15:51:36 +02:00
Thomas Müller 63fc5b601d
Ensure the user exists before calling a method on it - fixes #24751 2016-08-17 15:51:19 +02:00
Vincent Petry 3c2de97ab1 Disable NFD encoding wrapper by default
Seems I forgot to set it back to false after testing.
Will give a performance boost for all storages.
2016-08-17 14:45:18 +02:00
Lukas Reschke 6ed721dde3
Rename class reference
File has been renamed only on master
2016-08-16 21:28:26 +02:00
Arthur Schiwon 8ef08e46e8
add missing encryption modules to settings 2016-08-16 21:11:17 +02:00
Arthur Schiwon 4d505b72de
fix missing parameters in sharing settings page 2016-08-16 21:11:10 +02:00
Arthur Schiwon 6e37a007b9
check registered sections and settings after an app got updated to garbage collect orphaned classes 2016-08-16 21:10:57 +02:00
Arthur Schiwon 1e62bd3d92
attempt to remove section and settings entries when an app got disabled 2016-08-16 21:10:54 +02:00