Commit Graph

22730 Commits

Author SHA1 Message Date
Morris Jobke 7c98fbb043 Fix typo in error message
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-28 14:14:03 +00:00
Julius Härtl c86e568a5d Test for locking state in key generation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-10-28 14:14:02 +00:00
Julius Härtl dd4dc60f4c Harden key generation
There might be cases where multiple requests trigger the key generation
at the same time and the instance ends up with a non-fitting
public/private key pair. Therefore the whole key generation should be
locked. Other than that this makes sure that user key generation return
values are properly validated.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-10-28 14:14:01 +00:00
Morris Jobke 4d20a63d4f
Merge pull request #23734 from nextcloud/backport/23720/stable19
[stable19] save email as lower case
2020-10-28 08:49:10 +01:00
Nextcloud bot aa81a3045e
[tx-robot] updated from transifex 2020-10-28 02:19:10 +00:00
Robin Appelman fdc70c08c6 save email as lower case
email addresses are case insensitive

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-27 20:25:30 +00:00
Roeland Jago Douma e9cfc6fd10
Merge pull request #23705 from nextcloud/backport/23680/stable19
[stable19] Enable theming background transparency
2020-10-27 19:59:58 +01:00
Morris Jobke 93bc5ea744
Merge pull request #23714 from nextcloud/backport/23645/stable19
[stable19] Check if array elements exist before using them
2020-10-27 16:26:03 +01:00
Roeland Jago Douma 2cafd81d23 Check if array elements exist before using them
It seems that in some recent upgrade here. Not always the entries we
expect are returned. So we should first check if they exist. As to not
spam the log.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-27 11:00:27 +00:00
Arthur Schiwon 9c5bd23cf7 fixes determining whether former user is a share owner
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-27 08:49:04 +00:00
Arthur Schiwon 7544f0c508 split instantiation from business logic in OfflineUser
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-27 08:49:02 +00:00
Arthur Schiwon 394ec564af add test for active shares flag
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-27 08:49:00 +00:00
John Molakvoæ (skjnldsv) 09d4aa3010
Enable theming background transparency
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-27 09:06:12 +01:00
Nextcloud bot 238435f9b5
[tx-robot] updated from transifex 2020-10-27 02:18:54 +00:00
timm2k 76fb914944 Update CheckSetupController.php 2020-10-26 09:00:24 +00:00
Nextcloud bot 7983b230fa
[tx-robot] updated from transifex 2020-10-26 02:18:24 +00:00
Morris Jobke 236ed11b6b
Merge pull request #23647 from nextcloud/backport/23627/stable19
[stable19] Fix sharing input placeholder for emails
2020-10-25 21:59:13 +01:00
Nextcloud bot 1cba7f917c
[tx-robot] updated from transifex 2020-10-25 02:18:48 +00:00
John Molakvoæ (skjnldsv) 734edf9159 Fix sharing input placeholder for emails
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-24 09:09:38 +00:00
Roeland Jago Douma 353412b83d
Merge pull request #23424 from nextcloud/backport/23295/stable19
[stable19] Fix undefined index and consequential damages in versions code
2020-10-24 11:01:41 +02:00
Nextcloud bot cdbcd0ef12
[tx-robot] updated from transifex 2020-10-24 02:19:04 +00:00
Morris Jobke 50e532047e
Merge pull request #23637 from nextcloud/backport/23630/stable19
[stable19] Bring back the restore share button
2020-10-23 13:58:18 +02:00
Roeland Jago Douma bbc88ad708
Merge pull request #23585 from nextcloud/backport/23580/stable19
[stable19] Also expire share type email
2020-10-23 11:14:08 +02:00
Nextcloud bot e6b0df1986
[tx-robot] updated from transifex 2020-10-23 02:19:08 +00:00
Vincent Petry 2981961f59 Bring back the restore share button
Fix disabled default file action to still use an anchor element, as this
is used in many other places (and potentially apps).

Adjusted anchor style to not look like it's clickable and added extras
to make sure everything inside still looks clickable as before.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-10-22 19:01:18 +00:00
Nextcloud bot 428e2e9fee
[tx-robot] updated from transifex 2020-10-22 02:19:25 +00:00
Arthur Schiwon 59974c1fd5
tame psalm. why does it ignore '@property'?
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-21 16:26:48 +02:00
Arthur Schiwon 85d5ac5c91
when nesting is not enabled, the group filter can be applied right away
- helps performance, but skipping unnecessary entries
- reduces reoccuring info-level log output against groups that do not
  qualify ("no or empty name")

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-21 16:26:47 +02:00
Nextcloud bot 227d237690
[tx-robot] updated from transifex 2020-10-21 02:19:01 +00:00
John Molakvoæ (skjnldsv) d9c26c86a3
Also expire share type email
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-20 11:40:40 +02:00
Morris Jobke 3157ff441c
Merge pull request #23564 from nextcloud/backport/23497/stable19
[stable19] CalDavBackend: check if timerange is array before accessing
2020-10-20 09:56:44 +02:00
Nextcloud bot bca309a7ff
[tx-robot] updated from transifex 2020-10-20 02:18:58 +00:00
Simon Spannagel afb88e7719 CalDavBackend: check if timerange is array before accessing
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2020-10-19 11:16:49 +00:00
Nextcloud bot 0dfb367cd5
[tx-robot] updated from transifex 2020-10-19 02:18:15 +00:00
Nextcloud bot 5d638e23dc
[tx-robot] updated from transifex 2020-10-18 02:18:01 +00:00
Morris Jobke a4530c8942 SharedMountTest.php:367 is unreliable
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-16 06:43:40 +00:00
Nextcloud bot 53ce5e7eeb
[tx-robot] updated from transifex 2020-10-16 02:18:28 +00:00
John Molakvoæ e20b0c80a1
Merge pull request #23439 from nextcloud/disable-notify-self-check-19
[19] add option to disable notify self check
2020-10-15 15:11:12 +02:00
Nextcloud bot a5c17357b5
[tx-robot] updated from transifex 2020-10-15 02:18:41 +00:00
Robin Appelman c8a0ac921b
add option to disable notify self check
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-14 14:08:28 +02:00
Nextcloud bot 97f6388df2
[tx-robot] updated from transifex 2020-10-14 02:19:06 +00:00
Nextcloud bot bef065778a
[tx-robot] updated from transifex 2020-10-13 19:33:53 +00:00
blizzz 0e64bde969
Merge pull request #23233 from nextcloud/notify-saved-login-auth-19
[19] allow using saved login credentials for notify
2020-10-13 19:41:06 +02:00
Morris Jobke 264250937e Return all keys in getAllVersions() instead
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-13 15:46:34 +00:00
Christoph Wurst 92ac576e1c Fix undefined index and consequential damages in versions code
If the user has no space and there are no versions, there won't be an
`all` index in the versions entry. Hence this triggers a warning and
becomes `null`, afterwards `count`, `foreach` and friends will happily
throw even more warnings and errors because they don't want to play with
`null`. Thus adding a fallback to an empty array.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-13 15:46:31 +00:00
Morris Jobke 68c106b689 VersioningTest:729 is unreliable and should be disabled
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-13 07:13:14 +00:00
Nextcloud bot 17dd0b8248
[tx-robot] updated from transifex 2020-10-13 02:18:49 +00:00
Morris Jobke ad191f8846
Merge pull request #23282 from nextcloud/backport/23269/stable19
[stable19] Fix the user remove from group in UI
2020-10-12 21:39:37 +02:00
Sujith Haridasan 904e33abcb Fix the user remove from group in UI
Fix the removal of user from the group in UI.

Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-12 15:48:08 +00:00
Nextcloud bot 2a32e73fc2
[tx-robot] updated from transifex 2020-10-12 02:18:15 +00:00
Nextcloud bot 66a50d1a7f
[tx-robot] updated from transifex 2020-10-11 02:18:52 +00:00
Nextcloud bot 132efb8123
[tx-robot] updated from transifex 2020-10-10 02:18:54 +00:00
Nextcloud bot 8ac3a6d954
[tx-robot] updated from transifex 2020-10-09 02:18:54 +00:00
Roeland Jago Douma 759f47cba3
Merge pull request #23212 from nextcloud/backport/23096/stable19
[stable19] Also check the path based mimetype for flow rule checks
2020-10-08 11:52:09 +02:00
Nextcloud bot bafa390482
[tx-robot] updated from transifex 2020-10-08 02:18:54 +00:00
Robin Appelman 683142e1f3
also give storage backend it's change to manipulate the config
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-07 15:44:09 +02:00
Nextcloud bot bf530996d6
[tx-robot] updated from transifex 2020-10-07 02:18:24 +00:00
Robin Appelman 597cc797a1
allow using saved login credentials for notify
when only the user is provided, we use to provided user to try and get saved login credentials

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-06 17:05:31 +02:00
Roeland Jago Douma 8f5adecb3b
Merge pull request #23196 from nextcloud/backport/23175/stable19
[stable19] Fix legacy update notifications
2020-10-06 13:28:37 +02:00
Morris Jobke c75378ac86
Merge pull request #23186 from nextcloud/backport/23109/stable19
[stable19] dont hold a transaction during the move to trash
2020-10-06 09:11:44 +02:00
Julius Härtl 9e3bdcd63c Make sure to check the mimetype on the path if a secure one could not be detemined though the content
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-10-06 06:08:08 +00:00
Nextcloud bot 85e5e7141b
[tx-robot] updated from transifex 2020-10-06 02:18:48 +00:00
Sujith Haridasan 17705b69aa Fix the user email issue while creating a user
When the user is created, the provisioning api
was not adding the email address of the user
when provided if the `send email to new user`
is not set.

Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
2020-10-05 19:34:19 +00:00
mrtnmtth aa989b7777 Fix legacy update notifications
Signed-off-by: mrtnmtth <mrtn.mtth@gmx.de>
2020-10-05 14:08:14 +00:00
Robin Appelman f6bf519e55
dont hold a transaction during the move to trash
because moving to trash can take a long time, keeping a transaction active for the duration can lead to issues

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-05 15:27:31 +02:00
Nextcloud bot 3759bef671
[tx-robot] updated from transifex 2020-10-05 02:18:52 +00:00
Nextcloud bot a1b2b5ddd4
[tx-robot] updated from transifex 2020-10-04 02:18:24 +00:00
Nextcloud bot 993d07de8c
[tx-robot] updated from transifex 2020-10-02 11:06:28 +00:00
Roeland Jago Douma 8b25f10d2c
Merge pull request #23137 from nextcloud/fix/19/settings_ignore_js
[stable19] Fix ignoring the correct settings files for translations
2020-10-02 12:44:44 +02:00
Roeland Jago Douma 3250629946
[stable19] Fix ignoring the correct settings files for translations
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-02 12:34:54 +02:00
Roeland Jago Douma 916f6124b0
Merge pull request #22941 from nextcloud/backport/22395/stable19
[stable19] Fix settings chunk loading
2020-10-01 10:51:07 +02:00
Joas Schilling eec45af773
Merge pull request #23086 from nextcloud/backport/22983/stable19
[stable19] Sync all users to the system addresssbook
2020-10-01 09:31:03 +02:00
Nextcloud bot 99e5940a7f
[tx-robot] updated from transifex 2020-10-01 02:18:43 +00:00
Nextcloud bot 27d982e4bb
[tx-robot] updated from transifex 2020-09-30 02:18:26 +00:00
Joas Schilling ee29d6ab11 Sync all users to the system addresssbook
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-29 07:18:56 +00:00
Nextcloud bot 0d4ea5fc63
[tx-robot] updated from transifex 2020-09-29 02:18:06 +00:00
Roeland Jago Douma 164096aa26
Merge pull request #22804 from nextcloud/backport/stable19/22116-22648-22761
[stable19] Fix share transfer of single files and on the transfered node
2020-09-28 19:15:12 +02:00
Roeland Jago Douma bd037f8298
Merge pull request #22988 from nextcloud/backport/22533/stable19
[stable19] Flow: do not hide "matches" and "does not match" checkers
2020-09-28 19:13:17 +02:00
Roeland Jago Douma c091fbd5b9
Merge pull request #23002 from nextcloud/backport/22940/stable19
[stable19] Never copy the share link when the password is forced
2020-09-28 18:56:57 +02:00
Joas Schilling 2169b7d484
Never copy the share link when the password is forced
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-28 16:19:50 +02:00
Roeland Jago Douma 93dbaed5c3
Merge pull request #23049 from nextcloud/backport/23034/stable19
[stable19] Fix numeric folders throwing on markDirty
2020-09-28 15:00:56 +02:00
Nextcloud bot 26b1d3d9e4
[tx-robot] updated from transifex 2020-09-28 02:17:58 +00:00
Nextcloud bot a10b6c8277
[tx-robot] updated from transifex 2020-09-27 02:17:34 +00:00
Nextcloud bot 3b0a89be04
[tx-robot] updated from transifex 2020-09-26 02:17:59 +00:00
Joas Schilling 3fe6b5b5f8 Fix numeric folders throwing on markDirty
TypeError: strpos() expects parameter 1 to be string, int given

The problem is that in cacheNode() we strip of any slashes, so
a folder "0/" will be trimmed to "0" and be used as an array key.
Since PHP automatically casts numeric array keys to integers,
you afterwards get $nodePath as int(0). Since it's now a number,
the strpos() function does not accept it anymore. Simply casting
$nodePath to a string again in the foreach solves the issue

Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-25 13:14:58 +00:00
Nextcloud bot 066eafb172
[tx-robot] updated from transifex 2020-09-25 02:18:59 +00:00
Nextcloud bot 2c7b88454d
[tx-robot] updated from transifex 2020-09-24 02:17:59 +00:00
Nextcloud bot 617174b519
[tx-robot] updated from transifex 2020-09-23 02:18:00 +00:00
Arthur Schiwon 83beefc3eb
do not hide "matches" and "does not match" checkers
- they show up previously with / typed – end user needs to know about it
- inconsistent with some other fields, that show it directly

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-22 12:42:56 +02:00
Nextcloud bot dcceb1360f
[tx-robot] updated from transifex 2020-09-22 02:17:57 +00:00
Nextcloud bot c2977c5c0f
[tx-robot] updated from transifex 2020-09-21 02:17:33 +00:00
Nextcloud bot 1681e74d2d
[tx-robot] updated from transifex 2020-09-20 02:17:17 +00:00
Nextcloud bot c8f9fa1830
[tx-robot] updated from transifex 2020-09-18 19:05:38 +00:00
John Molakvoæ (skjnldsv) 9d15d718bb
Fix settings chunk loading
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-09-18 15:57:38 +02:00
Julius Härtl 7ea6ed6224
Merge pull request #22926 from nextcloud/backport/22915/stable19
[stable19] improve handling of out of space errors for smb
2020-09-18 13:13:36 +02:00
Nextcloud bot 34793138c7
[tx-robot] updated from transifex 2020-09-18 02:17:08 +00:00
Robin Appelman 67543d77a0 improve handling of out of space errors for smb
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-17 18:43:43 +00:00
Julius Härtl 818b69ec54
Transfer shares if no path provided
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-17 19:03:07 +02:00
Julius Härtl 14c3f1ebd8
Transfer shares of the transferred root node
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-17 19:03:07 +02:00
Nextcloud bot 8c2c8fd831
[tx-robot] updated from transifex 2020-09-17 02:27:15 +00:00