91ab811824
Verify that destination is not a directory.
...
Otherwise file_put_contents will fail later.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-14 12:52:12 +02:00
ebdf66b706
Provide dav setting for user's default calendar
...
And add tests to handle schedule-default-calendar-URL
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-13 15:07:42 +02:00
734c62bee0
Format code according to PSR2
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:56:50 +02:00
28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
1584c9ae9c
Add visibility to all methods and position of static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup
...
Remove all extra whitespace PSR2 does not like
2020-04-09 20:39:37 +02:00
64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords
...
Use php keywords in lowercase
2020-04-09 16:25:14 +02:00
44577e4345
Remove trailing and in between spaces
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
42625a46be
Remove spaces after method or function call
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:05:56 +02:00
36b3bc8148
Use php keywords in lowercase
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 14:04:56 +02:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
41b5e5923a
Use exactly one empty line after the namespace declaration
...
For PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +02:00
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
85e369cddb
Fix multiline comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +02:00
058ffa37ff
Add default titles for titleless events in invitations
...
Closes #19662
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-03 13:49:25 +02:00
bc6a5ef5c4
Merge pull request #19890 from nextcloud/enh/comments-reference-id
...
Add optional comments reference_id
2020-04-02 11:34:21 +02:00
81455479bc
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-02 09:59:44 +02:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
2200cc8562
Merge pull request #19325 from nextcloud/dependachristoph/composer/sabre-4.0
...
Update Sabre (and friends) to 4.0
2020-03-30 09:34:25 +02:00
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
...
Remove unused imports
2020-03-27 17:14:08 +01:00
55081b7fd2
RequestTestCase: Default type for headers needs to be array
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
80b7ef9b41
Adjust FakeLockerPluginTest to new Sabre version
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
5e2c802bb7
Set custom ProdId in Birthday service, do not depend on Sabre Versio number for unit tests
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
102a328e65
Fix usage of Sabre\HTTP\Request in unit tests
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
52ba75f644
Sabre/DAV 4.0: beforeMethod is now beforeMethod:*
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
2ee65f177e
Use the shorter phpunit syntax for mocked return values
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:21:27 +01:00
74936c49ea
Remove unused imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +01:00
3427653676
Merge pull request #19986 from nextcloud/bugfix/19980/fix_uid_as_uri
...
RefreshWebcalService: randomly generate calendar-object uri
2020-03-25 08:11:49 +01:00
3e338c9075
Merge pull request #18788 from nextcloud/fix/18782/translate-busy-in-caldav
...
Translate 'Busy' in CalDAV
2020-03-24 15:12:21 +01:00
01db6d4609
Add extra test case to exclude by timerange
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-03-22 14:24:13 +01:00
b0fbba05f2
Added test testSearch
...
Signed-off-by: dartcafe <github@dartcafe.de>
2020-03-22 14:24:13 +01:00
47271e56ee
Fix tests due to config adjustments
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-20 10:46:13 +01:00
0fa897fcfc
Limit enumeration in principal search
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-20 10:43:56 +01:00
861c897e93
fix tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-18 13:41:04 +01:00
15a21ee19a
remove the detour trough node and work with path directly
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-18 13:41:04 +01:00
451c8761a7
use INode instead of Node for custom properties
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-18 13:41:04 +01:00
7819a904d7
handle long property paths to hasing paths >250 chars
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-18 13:41:04 +01:00
e178718e74
test custom properties backend against real database
...
test behaviour not implementation
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-18 13:41:04 +01:00
ce398cf7bd
merge the two almost identical custom property backends
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-18 13:41:04 +01:00
bd1f98cba3
RefreshWebcalService: randomly generate calendar-object uri
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-16 15:36:13 +01:00
fc06b24838
Fix test
...
Signed-off-by: Nils Wittenbrink <nilswittenbrink@web.de>
2020-02-29 19:34:02 +01:00
e6206731c7
Merge pull request #19252 from nextcloud/bug/fix-notification-object-id
...
Hash event UID to make sure it's not too long for PushProvider notifications
2020-02-25 17:04:25 +01:00
713d3d49ad
Merge pull request #19196 from nextcloud/feature/17126/allow_apps_to_register_their_own_calendars
...
Allow apps to provide Calendars in user's calendarHome
2020-02-23 17:00:03 +01:00
709e7447ed
Translate 'Busy' in CalDAV
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-02-23 22:38:24 +08:00
354e8c1f2b
Introduce a default refresh rate app setting for calendar subscriptions
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-02-21 12:49:37 +01:00
b46e5cb270
Allow apps to provide Calendars in user's calendarHome
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-02-18 14:35:14 +01:00
8b22b9f046
Move RefreshWebcalJob logic to a proper service so that it may be called
...
independently
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-02-10 16:04:38 +01:00
8fba05db96
Check for empty authorization headers for office requests and allow anonymous option on the whole tree
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-02-04 15:35:23 +01:00
41fa057285
Hash event UID to make sure it's not too long for PushProvider
...
notifications
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-02-01 18:13:51 +01:00
98edf44c66
RefreshWebcalJob: Fix reading subscription from database leading to ignored refreshRate
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-01-30 13:04:42 +01:00
1b46621cd3
Update license headers for 18
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-20 09:23:25 +01:00
8d7baaff74
Merge pull request #18061 from nextcloud/bugfix/noid/dav-plugin-old
...
Load apps dav plugins on the old webdav route
2019-12-16 13:38:38 +01:00
27a31cdaf1
Support more IPv6 addresses in the RefreshWebcalJob
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-12-12 10:05:36 +01:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +01:00
63cb31542d
Merge pull request #17941 from nextcloud/search-by-owner
...
Allow filtering the search results to the users home storage
2019-12-05 11:04:33 +01:00
1593322397
Load apps dav plugins on the old webdav route
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-12-04 19:04:29 +01:00
c62637da8b
Allow filtering the search results to the users home storage
...
This is done by adding a
```xml
<d:eq>
<d:prop>
<oc:owner-id/>
</d:prop>
<d:literal>$userId</d:literal>
</d:eq>
```
clause to the search query.
Searching by `owner-id` can only be done with the current user id
and the comparison can not be inside a `<d:not>` or `<d:or>` statement
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-12-03 13:49:37 +01:00
c3748cfee3
respect shareapi_allow_share_dialog_user_enumeration in Principal backend for Sabre/DAV
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-12-03 09:44:07 +01:00
6d39c6cb50
Set common-name to user's displayname if none is set
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-11-29 07:48:30 +01:00
3a7cf40aaa
Mode to modern phpunit
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 15:27:18 +01:00
8d4346d656
Fix more tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:42 +01:00
9463e2cf61
Fix SynserviceTest
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:42 +01:00
a5b8473aa5
Fix fileplugintest
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:42 +01:00
ef4b59d341
More fixes
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:42 +01:00
c007ca624f
Make phpunit8 compatible
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:41 +01:00
68748d4f85
Some php-cs fixes
...
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +01:00
2e97e8bf84
re-acquired expired shared locks on large file uploads
...
during large file uploads, the shared lock that we get at the begining can expire
leading to locked errors later on, instead of erroring, try to re-get the lock
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-11-13 14:54:22 +01:00
e8095cf737
use OCP\EventDispatcher\Event over Symfony's deprecated Event
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-10-17 13:31:48 +02:00
88f6d1c20e
Make push notifications for calendar reminders opt-in
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-09-02 15:18:43 +02:00
e99fa92456
Merge pull request #16615 from nextcloud/feature/16518/rooms_resources_should_respond
...
Make rooms / resources automatically reply to invites
2019-08-28 09:34:38 +02:00
cc37c39ede
Make rooms / resources automatically reply to invites
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-08-26 13:27:59 +02:00
befe38e1d7
replace coffin with textual description "Death of ..."
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-08-26 10:36:49 +02:00
6f66fba559
fix foreach error for reminder generator
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-08-18 20:56:57 +02:00
4d28a4544e
Final fixes
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-08-15 20:05:01 +02:00
7bddcc091d
Support event reminders (email and notifications)
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2019-08-15 20:02:56 +02:00
f452e23a7d
Merge pull request #16666 from nextcloud/feature/calendar/delegation
...
Feature/calendar/delegation
2019-08-15 19:30:45 +02:00
63d584afb5
use principaluri instead of userid, allowing to add delegates for rooms and things
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
!fixup add owner_id and proxy_id as db index, since we use it for querying
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
!fixup don't add ACL for each individual proxy, just use calendar-proxy groups
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
!fixup allow delegation of resources / rooms
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
!fixup fix addIndex call in migration
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
!fixup fix remaining constructor calls of Principal
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
!fixup minor fixes and unit tests
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-08-15 15:41:28 +02:00
954290ab5f
Merge pull request #12392 from brad2014/feature/properly-present-buttons-from-imip-mails
...
Customize presentation of accept/decline buttons in iMip mail
2019-08-15 08:17:30 +02:00
34868f0964
Merge pull request #14429 from tobiasKaminsky/shareesOnDav
...
Show sharees via propfind
2019-08-13 20:22:47 +02:00
a85392615d
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-08-11 21:34:28 +02:00
ab6add54c7
Allow to do a principal property search based on metadata keys
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-08-01 19:40:27 +02:00
4b4292996f
Test resource and room principal backend to check that they provide metadata
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-08-01 15:05:53 +02:00
31d6138f46
Test sync of resource and room metadata
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-08-01 14:05:47 +02:00
85d5400314
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-08-01 10:02:25 +02:00
8d8bcea1d8
Move dav.invitation_link_recipients from getSystemValue to getAppValue
...
Per @georgehrke change request for PR #12392 , instead of setting
dav.invitation_link_recipients in the system config.php file, we
set it in the database table oc_appconfig.
Furthermore, the value of the config variable is always a string:
'yes' to include links in imip mail, 'no' to exclude them, or a
comma-separated list of email addresses and/or domains for which
they should be included. If not specified in oc_appconfig, the
default is 'yes'.
Signed-off-by: brad2014 <brad2014@users.noreply.github.com>
2019-07-31 12:55:50 -07:00
a085a88205
Merge pull request #14954 from tacruc/searchPatterns
...
Allow to search for real pattern in contacts
2019-07-19 18:03:37 +02:00
3b6df74a6d
add test for overwriting in non creatable directory
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-07-03 16:36:27 +02:00
089a421ece
RefreshWebcalJob: replace ugly Regex with standard php utils
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-07-02 20:04:54 +02:00
3174012adf
Add event dispatcher to OCP
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-06-25 10:02:27 +02:00
357263a70b
Do not try to autoload built in types
...
This avoids calls to the autoloader (or chain of autoloaders) to see if
for example 'principalPrefix' class can be found. While we already know
it is a string.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-06-04 15:13:32 +02:00
2c5ebac458
Allow to search for real pattern in contacts
...
Added an option escape_like_param to allow wildcards
Signed-off-by: Arne Hamann <kontakt+github@arne.email>
2019-05-28 10:01:56 +02:00
7ec8e6d35b
Don't run repair step for every individual user, outsource that to background job
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-05-23 11:24:32 +02:00
33946655b9
Merge pull request #15141 from nextcloud/fix/noid/regenerate-seen-users-only
...
fix searching all users in repair regenerate birthday cal reparir job
2019-04-24 19:58:53 +02:00
96bab4f969
remove obsolete use statements
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-04-24 16:24:53 +02:00
c16d116fa6
Prefetching blows up if there are a lot of files.
...
I saw instances where people had a lot of files (each with custom
properties) and all this prefetching blew up and started to consume an
insane amount of RAM resulting in the process getting killed.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-04-18 21:23:59 +02:00
d74e49b3e6
implement principal property search for calendar user address set property
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-03-21 16:32:41 +01:00
8ff536f4f7
Merge pull request #14641 from nextcloud/assemblystream-seek
...
make assemblystream seekable
2019-03-15 12:25:28 +01:00
Daniel Kesselberg
Thomas Citharel
Christoph Wurst
Christoph Wurst
Joas Schilling
Joas Schilling
Roeland Jago Douma
Georg Ehrke
dartcafe
Julius Härtl
Robin Appelman
Nils Wittenbrink
Gary Kim
Roeland Jago Douma
Arthur Schiwon
brad2014
Morris Jobke
Arne Hamann