Lukas Reschke
e2453d78c0
Properly catch whether a share is `null`
...
Despite it's PHPDoc the function might return `null` which was not properly catched and thus in some situations the share was resolved to the sharing users root directory.
To test this perform the following steps:
* Share file in owncloud 7 (7.0.4.2)
* Delete the parent folder of the shared file
* The share stays is in the DB and the share via the sharelink is inaccessible. (which is good)
* Upgrade to owncloud 8 (8.0.2) (This step is crucial. The bug is not reproduceable without upgrading from 7 to 8. It seems like the old tokens are handled different than the newer ones)
* Optional Step: Logout, Reset Browser Session, etc.
* Access the share via the old share url: almost empty page, but there is a dowload button which adds a "/download" to the URL.
* Upon clicking, a download.zip is downloaded which contains EVERYTHING from the owncloud directory (of the user who shared the file)
* No exception is thrown and no error is logged.
This will add a check whether the share is a valid one and also adds unit tests to prevent further regressions in the future. Needs to be backported to ownCloud 8.
Adding a proper clean-up of the orphaned shares is out-of-scope and would probably require some kind of FK or so.
Fixes https://github.com/owncloud/core/issues/15097
2015-03-24 11:21:58 +01:00
Jenkins for ownCloud
9cb07f126d
[tx-robot] updated from transifex
2015-03-24 01:55:24 -04:00
blizzz
8906158d3b
Merge pull request #15123 from owncloud/fix_14098
...
offset needs to be considered in computed limit
2015-03-23 17:50:24 +01:00
Lukas Reschke
02c0fe8d43
Merge pull request #13941 from owncloud/fix-folder-upload-on-firefox
...
Show message if upload of folder isn't allowed
2015-03-23 17:18:46 +01:00
Arthur Schiwon
7520d0fb3d
offset needs to be considered in computed limit
2015-03-23 16:51:40 +01:00
Morris Jobke
7f2b06dfa0
Merge pull request #15120 from owncloud/ldap-occ-fix-warnings
...
fix PHP warnings when using occ with some LDAP commands
2015-03-23 16:29:27 +01:00
Arthur Schiwon
468fc675a4
fix PHP warnings when using occ with some LDAP commands
2015-03-23 15:19:41 +01:00
Joas Schilling
1a26263123
Do not walk over the users directory, but over the list of tagged objects
...
Way quicker
2015-03-23 15:10:58 +01:00
Clark Tomlinson
0e4ba618cf
Merge pull request #14383 from jknockaert/newbranch
...
make encryption stream wrapper seekable
2015-03-23 09:22:36 -04:00
Jenkins for ownCloud
a9b4f0d842
[tx-robot] updated from transifex
2015-03-23 01:54:48 -04:00
Jenkins for ownCloud
a79d973005
[tx-robot] updated from transifex
2015-03-22 01:55:21 -04:00
Roeland Jago Douma
bdde2156da
Added extra unit test
2015-03-21 09:47:07 +01:00
Roeland Jago Douma
9ce8e1ddc7
OCS API should return fancy OC url
...
* Also use the URLGenerator
2015-03-21 09:47:06 +01:00
Jenkins for ownCloud
e36a33c89a
[tx-robot] updated from transifex
2015-03-21 01:56:09 -04:00
Robin McCorkell
1f3fdf17ef
Support constructing an SMB_OC without saved session credentials
2015-03-20 16:24:30 +00:00
Thomas Müller
afa8872955
Merge pull request #14857 from owncloud/preview-provider-registration-in-manager
...
Preview provider registration in manager
2015-03-20 16:34:22 +01:00
Vincent Petry
e44ab2dcfe
Merge pull request #11884 from owncloud/ext-appframework
...
Cleanup ext storage CRUD code, introduce storage config id
2015-03-20 14:17:32 +01:00
Vincent Petry
67160e0861
Do not automatically add "update" permission to shared mounts
...
In the past it seems the update permission was needed to be able to
rename shared mounts, but it doesn't seem to be the case any more.
Removing the "update" permission that used to be added automatically
fixes the read-only permission check when trying to overwrite a
read-only file over WebDAV.
2015-03-20 12:33:59 +01:00
Vincent Petry
eef5851a67
Fix share permission related unit tests
2015-03-20 11:30:51 +01:00
Robin McCorkell
c37913b1d5
Introduce async status checking
2015-03-20 09:48:14 +00:00
Joas Schilling
7776e088d6
Group sharing activities by user/group and file respectively
2015-03-20 09:49:33 +01:00
Jenkins for ownCloud
e8680e6637
[tx-robot] updated from transifex
2015-03-20 01:55:23 -04:00
Vincent Petry
5f7b3a4dbe
Rename must be possible with update-only permission
...
and this as long as the rename is done within the same folder.
2015-03-19 21:55:56 +01:00
Thomas Müller
c57fb62029
Merge pull request #14946 from owncloud/dropbox-root-fix
...
Fix root request path for Dropbox
2015-03-19 17:19:57 +01:00
Thomas Müller
857b22c61b
Merge pull request #15025 from rullzer/ocs_respect_enforced_date
...
Ocs respect enforced date
2015-03-19 17:06:04 +01:00
Robin Appelman
be6edd465a
Merge pull request #14537 from owncloud/oci-external-share
...
Fix external shares without password on oracle
2015-03-19 16:20:12 +01:00
Roeland Jago Douma
dd3307dd19
Added unit test
...
Tests added to make sure that removing an expire date when this is
enforced is not allowed.
2015-03-19 10:47:09 +01:00
Jenkins for ownCloud
e40b0701d7
[tx-robot] updated from transifex
2015-03-19 01:55:06 -04:00
Vincent Petry
a9e6eba018
Reenable trashbin after failed rename
...
After a failed rename, the post_rename hook is not called.
This quickfix makes sure the trashbin storage logic is reenabled
also after a failed rename.
2015-03-18 19:56:31 +01:00
Vincent Petry
c2315aa015
Fix shared storage permission checks
2015-03-18 19:56:31 +01:00
Jan-Christoph Borchardt
e5fd6816df
fix position of 'Deleted files' sidebar entry, fix #10815
2015-03-18 13:31:16 +01:00
Jenkins for ownCloud
8a95bf18b7
[tx-robot] updated from transifex
2015-03-18 01:55:22 -04:00
Robin McCorkell
760f5fc5e5
Merge pull request #14954 from owncloud/cache-image-path
...
Cache \OC\URLGenerator::imagePath
2015-03-17 19:36:23 +00:00
Morris Jobke
f4b6f3cfd1
fix unit tests
2015-03-17 18:55:44 +01:00
Joas Schilling
8ebb198ef3
Add a unit test for the naming conflict on the mountpoint name
2015-03-17 16:55:03 +01:00
Jan-Christoph Borchardt
ce89f12566
add whitespace to prevent file deletion when wanting to scroll
2015-03-17 16:54:42 +01:00
Joas Schilling
ba3e4ede39
Use insertIfNotExists() instead of manual logic
2015-03-17 16:03:24 +01:00
Joas Schilling
05c4848954
Correctly get the unique mountpoint name when mounting the share
...
Previously the mount name was checked for uniqueness prior to inserting the
share. This caused problems, when two shares with the same name where done
or folder, mount point, local share with the same name was done, between
sending and accepting of the remote share
2015-03-17 16:03:24 +01:00
Lukas Reschke
9e2ebf2dce
Cache \OC\URLGenerator::imagePath
...
\OC\URLGenerator::imagePath is a really expensive operation due to all the I/O handling and can really benefit from caching.
2015-03-17 12:35:47 +01:00
Joas Schilling
9c45ab49a1
Use a closure for the files app entry and deprecate old methods
2015-03-17 12:17:09 +01:00
Vincent Petry
e5e30924b1
Fix PHPDoc in files_external, add missing tag
...
Fix various PHPDoc issues in external storage app.
Added missing NoAdminRequired tag
2015-03-17 11:42:52 +01:00
Vincent Petry
5b6ecb2d98
Fix root request path for Dropbox
2015-03-17 10:56:24 +01:00
Lukas Reschke
db033e4e19
Fix PHPDoc and Co.
...
Ref https://github.com/owncloud/core/pull/14929#discussion_r26501240
2015-03-17 10:37:09 +01:00
Vincent Petry
6525911439
Merge pull request #14929 from owncloud/s2s-scanner-warnings
...
Fix scanFile signature warnings
2015-03-17 09:51:45 +01:00
Jenkins for ownCloud
b51b4f0a2c
[tx-robot] updated from transifex
2015-03-17 01:55:43 -04:00
Vincent Petry
669ff45625
Merge pull request #14877 from owncloud/smb-constructor-noconnect
...
Wait with getting the timezone from the smb server until we need it
2015-03-16 17:01:49 +01:00
Vincent Petry
b9d9405135
Fix scanFile signature warnings
2015-03-16 16:45:11 +01:00
Vincent Petry
847880803e
Fix storage priority in JS unit test
2015-03-16 15:07:38 +01:00
Vincent Petry
06448170cf
Fix PHPDoc for StoragesController
2015-03-16 14:39:48 +01:00
Joas Schilling
3052b9571e
Fix controller test
2015-03-16 12:45:18 +01:00
Joas Schilling
47af533183
Move mimetype check from template to controller
2015-03-16 12:45:18 +01:00
Joas Schilling
4c4c0fa120
Use the PreviewManager where possible
2015-03-16 12:44:10 +01:00
Vincent Petry
72632ad402
Generate storage config ids when missing
...
When reading in old mount.json files, they do not contain config ids.
Since these are needed to be able to use the UI and the new service
classes, these will be generated automatically.
The config grouping is based on a config hash.
2015-03-16 12:18:01 +01:00
Thomas Müller
1e0d8f1774
Merge pull request #14133 from rullzer/fix_10600
...
Always display max upload size in admin panel
2015-03-16 10:05:57 +01:00
Thomas Müller
bbaf97ca43
Merge pull request #14644 from owncloud/trash-expire-command
...
Expire files from the trash in the background
2015-03-16 10:04:05 +01:00
Thomas Müller
b159c7f274
Merge pull request #14848 from owncloud/kill-curl-fallback-master
...
drop any fallback code related to curl
2015-03-16 09:56:31 +01:00
Jenkins for ownCloud
c1a3394f48
[tx-robot] updated from transifex
2015-03-16 01:55:15 -04:00
Jenkins for ownCloud
84b6ca9b81
[tx-robot] updated from transifex
2015-03-15 01:54:38 -04:00
Jenkins for ownCloud
8c5be2bc48
[tx-robot] updated from transifex
2015-03-14 01:54:45 -04:00
Vincent Petry
fb4cf53253
Fix mount config unit tests
...
Fix expected result now that it returns the status.
Added isset for some properties that are not always present.
2015-03-13 17:43:38 +01:00
Robin Appelman
3159af1983
Wait with getting the timezone from the smb server until we need it
2015-03-13 14:36:34 +01:00
Vincent Petry
34c8b1ac77
Mount options for ext storage are now passed around
...
The mount options are now passed to the UI and stored in a hidden field.
The ext storage controllers and services also know how to load/save them
from the legacy config.
2015-03-13 12:49:11 +01:00
Arthur Schiwon
f28f7754ae
support paged results against 389ds.
2015-03-12 22:47:20 +01:00
Thomas Müller
5855108e9b
drop any fallback code related to curl - refs https://github.com/owncloud/core/pull/14838#issuecomment-78586447
2015-03-12 21:43:41 +01:00
Robin McCorkell
680ec056dc
Implement priority on client side in hidden input
2015-03-12 18:51:02 +01:00
Vincent Petry
ce94a998dd
Use storage id + appframework for ext storage CRUD
...
- Added StorageConfig class to replace ugly arrays
- Implemented StorageService and StorageController for Global and User
storages
- Async status checking for storages (from Xenopathic)
- Auto-generate id for external storage configs (not the same as
storage_id)
- Refactor JS classes for external storage settings, this mostly
moves/encapsulated existing global event handlers into the
MountConfigListView class.
- Added some JS unit tests for the external storage UI
2015-03-12 18:51:02 +01:00
Thomas Müller
5054b8e4aa
Merge pull request #14785 from owncloud/issue/14733-active-class-missing-for-admin-navigation-entry
...
Do not overwrite the active menu entry of the navigation
2015-03-12 10:45:03 +01:00
Jenkins for ownCloud
454a2563bc
[tx-robot] updated from transifex
2015-03-12 01:55:59 -04:00
Roeland Jago Douma
ec31ee9117
Mark functions private
2015-03-11 16:30:54 +01:00
Lukas Reschke
cf25e6f569
Merge pull request #14773 from owncloud/allow-iframes-from-self-in-share-view
...
Allow iframes from same domain in share view
2015-03-11 15:13:59 +01:00
Roeland Jago Douma
e9a003fe21
Slight better formatting
2015-03-11 15:11:50 +01:00
Roeland Jago Douma
09ee297356
New array syntax
2015-03-11 15:02:55 +01:00
Roeland Jago Douma
c985186246
Added new header
2015-03-11 15:02:55 +01:00
Roeland Jago Douma
af76716775
Now added enabled element
...
This change allows for more generic parsing for the capabilities.
2015-03-11 15:02:55 +01:00
Roeland Jago Douma
0bf1152a51
Added route again
2015-03-11 15:02:55 +01:00
Roeland Jago Douma
39b0f0725e
Add file_sharing info to capabilities
...
Display the capabilities regarding file sharing in the capabilities API.
This will allow the clients to provide users a better experince.
2015-03-11 15:02:55 +01:00
Thomas Müller
0f3e36fdfd
Adding a more meaningful message for sabre dav exception - fixes #14516
2015-03-11 11:53:31 +01:00
Joas Schilling
6a677ce8fe
Do not make setupMounts() public just because of testing
2015-03-11 11:10:43 +01:00
Joas Schilling
981c60f5f5
Do not overwrite the active menu entry of the navigation
2015-03-11 09:27:28 +01:00
Jenkins for ownCloud
01ea056ac8
[tx-robot] updated from transifex
2015-03-11 01:55:38 -04:00
Thomas Müller
1757d01604
Merge pull request #14640 from owncloud/rescanversionsonlyonce
...
Only rescan versions once in trashbin
2015-03-11 00:54:20 +01:00
Thomas Müller
4ffca58bc4
don't rely on \OCP\User::getUser() - it is not set properly in case of async operations
2015-03-10 11:47:52 +01:00
Thomas Müller
7cb6811a7b
tearDown the filesystem right before setting it up again
2015-03-10 11:47:06 +01:00
Lukas Reschke
6dc59019af
Merge pull request #14346 from owncloud/storage-based-path-validation
...
adding storage specific filename verification
2015-03-10 11:02:47 +01:00
Robin Appelman
dcd2d7aff5
Add unit tests for external share mananger
2015-03-10 10:17:53 +01:00
Lukas Reschke
48243a2949
Allow iframes from same domain in share view
...
This is required because the PDF Viewer itself is embedded using an iframe from the same domain. The default policy is blocking this.
Going on further, we have to come up with a solution in the future how to handle previews by applications, one example might be that they call their own endpoint and not the generic share page to allow applications to have full control over how to display previews.
Anyways, to test this behaviour use a decent newer browser (such as Chrome 41) and share a PDF file, obviously the PDF viewer needs to be enabled as well. Without this patch publicly shared PDF files should not get previewed and an error is thrown. (if it isn't then your browser is probably not obeying our Content-Security-Policy and you might consider switching to another one ;))
2015-03-10 10:06:15 +01:00
Jenkins for ownCloud
e069d9d3f9
[tx-robot] updated from transifex
2015-03-10 01:55:39 -04:00
Morris Jobke
94b7fa17c5
Merge pull request #14720 from owncloud/fix-shareetagpropagation
...
Fix size propagation over shared storage boundary
2015-03-09 16:24:06 +01:00
Vincent Petry
ec19d9c267
Add unit test for size propagation across share boundaries
2015-03-09 12:56:22 +01:00
Thomas Müller
abacfd84da
fixing js unit tests
2015-03-09 10:38:38 +01:00
Thomas Müller
4bac595068
adding storage specific filename verification - refs #13640
2015-03-09 10:38:37 +01:00
Morris Jobke
348fe105b1
Merge pull request #14706 from owncloud/ldap-reset-paged-search-on-null-limit
...
LDAP: set up paged search even if limit is 0
2015-03-09 08:12:25 +01:00
Jenkins for ownCloud
174f8cef64
[tx-robot] updated from transifex
2015-03-09 01:54:36 -04:00
Jenkins for ownCloud
377165ae51
[tx-robot] updated from transifex
2015-03-08 01:54:36 -05:00
Jenkins for ownCloud
73c2157171
[tx-robot] updated from transifex
2015-03-07 01:54:37 -05:00
Jenkins for ownCloud
d11f040720
[tx-robot] updated from transifex
2015-03-06 01:54:52 -05:00
Vincent Petry
4322287fc3
Fix size propagation over shared storage boundary
2015-03-05 22:23:47 +01:00
Arthur Schiwon
42d3ed47e2
set up paged search when limit is 0
2015-03-05 13:15:21 +01:00
Jenkins for ownCloud
7e0fd8fb50
[tx-robot] updated from transifex
2015-03-05 01:56:35 -05:00
Morris Jobke
cffc256479
Merge pull request #14672 from Crote/master
...
Add --show-password option to ldap:show-config
2015-03-04 20:21:14 +01:00
Vincent Petry
e56727e27b
Merge pull request #14690 from owncloud/trash-deletelink-unittest
...
Add unit test for selection overlay actions in trashbin
2015-03-04 14:50:11 +01:00
Laurens Post
8149217371
Add --show-password option to ldap:show-config
2015-03-04 14:15:33 +01:00
Vincent Petry
3f6e7d6a43
Add unit test for selection overlay actions in trashbin
2015-03-04 13:49:19 +01:00
Thomas Müller
2831a1790c
Merge pull request #14675 from owncloud/files-external-smb-windows
...
adding a windows smb config for testing to ci
2015-03-04 12:27:59 +01:00
Robin McCorkell
ed4dc4db07
Fix slash normalization error in AmazonS3Migration unit test
...
Since aa821ecc00
leading and trailing slashes are
trimmed in the file cache paths
2015-03-04 09:22:21 +00:00
Jenkins for ownCloud
84785a6a39
[tx-robot] updated from transifex
2015-03-04 01:55:19 -05:00
Robin McCorkell
d6b9b37ddb
Use dummy storages instead of real storages in files_external unit tests
...
We were using the SMB and SFTP backends, which since Icewind's new SMB library
results in an actual attempted connection just by constructing the storage.
This commit replaces all references to real storages (except when necessary)
with a dummy storage class.
2015-03-03 17:29:17 +01:00
Thomas Müller
7d3e228365
adding a windows smb config for testing
2015-03-03 17:29:10 +01:00
Vincent Petry
133c37fe22
Merge pull request #14652 from owncloud/kill-download-from-url
...
Remove "Download from URL" feature
2015-03-03 10:10:15 +01:00
Jenkins for ownCloud
e271fa3ee8
[tx-robot] updated from transifex
2015-03-03 01:55:50 -05:00
Thomas Müller
345c527ed0
remove $content parameter
2015-03-02 21:33:17 +01:00
Lukas Reschke
acabd81f42
Remove "Download from URL" feature
...
Fixes https://github.com/owncloud/core/issues/13326
2015-03-02 21:06:25 +01:00
Robin Appelman
c80522ed63
Expire files from the trash in the background
2015-03-02 15:25:50 +01:00
Vincent Petry
e61aa3723e
Merge pull request #14573 from owncloud/enc-migrate-disable-updater
...
Disable the cache updater when doing the encryption migration
2015-03-02 14:53:29 +01:00
Vincent Petry
7432c73f5c
Only rescan versions once in trashbin
...
Whenever versions need to be rescanned, only do it once per PHP request.
Happens whenever multiple files need to be expired.
2015-03-02 12:59:38 +01:00
Thomas Müller
58ec0ea734
Merge pull request #14535 from owncloud/fix-files-external
...
fix files external test run and add common-tests option
2015-03-02 00:51:38 -08:00
Morris Jobke
7194952db4
Merge pull request #14570 from rullzer/ocs_sane_permissions
...
Shares should have a least read permission
2015-03-02 08:38:36 +01:00
Jenkins for ownCloud
3f91e3757f
[tx-robot] updated from transifex
2015-03-02 01:55:00 -05:00
Roeland Jago Douma
4436a9ce35
Shares should have a least read permission
...
* Throw 400 when a share is created or updated without read permissions
* Added unit tests
2015-03-01 17:13:17 +01:00
Jenkins for ownCloud
ff85d38c2a
[tx-robot] updated from transifex
2015-03-01 01:54:38 -05:00
Jenkins for ownCloud
42f6448da2
[tx-robot] updated from transifex
2015-02-28 01:55:32 -05:00
Vincent Petry
22bc622f9b
Move keys instead of copy during encryption key migration
2015-02-27 17:14:17 +01:00
Robin Appelman
6f000ffc7b
Disable the cache updater when doing the encryption migration
2015-02-27 17:14:16 +01:00
Robin Appelman
c65c717379
Fix external shares without password on oracle
2015-02-27 13:22:57 +01:00
Thomas Müller
f72f9e0159
Merge pull request #14530 from owncloud/revert-14403
...
Revert "Updating license headers"
2015-02-27 00:39:29 -08:00
Thomas Müller
64138b0af5
Merge pull request #14561 from owncloud/fix-sftp
...
apply suggestions from @atmoz to fix SFTP setup
2015-02-27 00:02:39 -08:00
Jenkins for ownCloud
d20061e5b1
[tx-robot] updated from transifex
2015-02-27 01:55:28 -05:00
Morris Jobke
63f5d7d3d6
apply suggestions from @atmoz to fix SFTP setup
2015-02-26 23:49:18 +01:00
Vincent Petry
1777609d47
Merge pull request #14532 from owncloud/defaultvalueforremoteid
...
Add default value for remote_id
2015-02-26 16:46:12 +01:00
Morris Jobke
0c1e6fad6c
Merge pull request #14300 from owncloud/commandbus
...
Add async command system to handle asynchronous operations
2015-02-26 15:10:13 +01:00
Vincent Petry
80e5ad3131
Bump up files_sharing version for schema update
2015-02-26 15:04:15 +01:00
Morris Jobke
7b2b74d731
Merge pull request #14473 from owncloud/remove-uneeded-assignment
...
Remove uneeded assignment
2015-02-26 14:01:21 +01:00
Morris Jobke
62d54e4c2a
fix files external test run and add common-tests option
2015-02-26 13:32:44 +01:00
Vincent Petry
ba71ee6059
Add default value for remote_id
...
Fixes SQLite migration with non-null column.
2015-02-26 12:09:21 +01:00
Morris Jobke
06aef4e8b1
Revert "Updating license headers"
...
This reverts commit 6a1a4880f0
.
2015-02-26 11:37:37 +01:00
Thomas Müller
adc986f3e4
Merge pull request #14502 from owncloud/failing-mysql-master-tests
...
Failing mysql master tests
2015-02-26 01:48:37 -08:00
Joas Schilling
fe8df31fa5
Sort the array to be sure
2015-02-26 09:13:09 +01:00
Jenkins for ownCloud
8a4fddeb4a
[tx-robot] updated from transifex
2015-02-26 01:55:50 -05:00
Lukas Reschke
94bf2c8d6d
Merge pull request #14509 from owncloud/fix/14231
...
Show 404 page when accessing empty share URL
2015-02-25 21:39:49 +01:00
Lukas Reschke
921a76ae2e
Merge pull request #14245 from cmeh/master
...
Message clean-up
2015-02-25 17:46:41 +01:00
Lukas Reschke
fca4628a5c
Show 404 page when accessing empty share URL
...
Testplan:
- [ ] Without: Accessing `public.php?service=files&t=` throws an exception
- [ ] With: No exception thrown and 404 page displayed.
Fixes https://github.com/owncloud/core/issues/14231
2015-02-25 17:29:12 +01:00
Joas Schilling
ac5bb97d04
Reset the group backend aswell
2015-02-25 16:03:12 +01:00
Joas Schilling
993d89b3cc
Extend the class so the Filesystem is cleaned up
2015-02-25 16:03:10 +01:00
Robin Appelman
bf65b1f18b
Rename getAsyncCommandBus to getCommandBus
2015-02-25 15:09:41 +01:00
Robin Appelman
27d047979d
require command that do file access to be run sync when encryption is enabled
2015-02-25 15:09:41 +01:00
Robin McCorkell
695f43a1ed
Merge pull request #10735 from owncloud/use_remote_addr
...
Use getRemoteAddress which supports reverse proxies
2015-02-25 13:24:39 +00:00
Thomas Müller
f5b6226732
Merge pull request #14462 from owncloud/add-some-php-docs
...
Add some PHPDocs
2015-02-25 02:53:22 -08:00
Thomas Müller
f6044fe429
Merge pull request #14460 from owncloud/revive/12971
...
Add support for sftp custom port
2015-02-25 02:52:25 -08:00
Robin McCorkell
af96078153
Merge pull request #14475 from owncloud/fix-ext-owncloud
...
Fix bugs in ownCloud external storage
2015-02-25 10:39:25 +00:00
Thomas Müller
799e144b04
Merge pull request #14151 from owncloud/update-sabre2.1
...
Sabre Update to 2.1
2015-02-25 02:21:55 -08:00
Robin McCorkell
edfeb05a05
Fix bugs in ownCloud external storage
2015-02-25 10:10:13 +00:00
Thomas Müller
b3de86d851
Remove locks plugin.
...
Reasoning:
- a WebDAV server is not required to implement locking support
- WebDAV Locking is know to break the sync algorithm
- the current lock implementation is known to be broken (locks are not moved if a file is moved, locks on shared files don't work)
2015-02-25 10:30:47 +01:00
Jenkins for ownCloud
31f881415b
[tx-robot] updated from transifex
2015-02-25 01:55:51 -05:00
Lukas Reschke
5bb0889b30
Remove uneeded assignment
...
'files' is neither used in the controller or the template
2015-02-24 19:50:23 +01:00
Thomas Müller
09a06e4f0a
Merge pull request #14068 from owncloud/autotest-external-sftp
...
[files_external] sftp tests
2015-02-24 08:06:27 -08:00
Lukas Reschke
52495dc995
Merge pull request #13740 from owncloud/fix-12190-2
...
Include primary groups in user and login filter when restricting group access and also fix user counting in primary groups
2015-02-24 16:37:49 +01:00
Lukas Reschke
dbb665a361
Add some PHPDocs
...
My IDE was crying...
2015-02-24 13:44:40 +01:00
Lukas Reschke
1229184873
Fix code that never worked
...
Introduced with 1df8a5a774
in February 2013…
2015-02-24 13:26:23 +01:00
Lukas Reschke
6dd5bc0379
Fix code style as per review
2015-02-24 13:22:12 +01:00
SA
350f8eb86e
Add support for sftp custom port
2015-02-24 13:15:38 +01:00
Lukas Reschke
165afb004b
Use getRemoteAddress which supports reverse proxies
...
Breaking change for 8.1 wiki (Security > Administrators):
The log format for failed logins has changed and uses now the remote address and is considering reverse proxies for such scenarios when configured correctly.
2015-02-24 11:49:40 +01:00
cmeh
649a1ba255
Typo: Missing "n"
...
A missing "n" was added in line 63.
2015-02-24 10:15:56 +01:00
Joas Schilling
a320edaca5
Merge pull request #14419 from owncloud/preview_apostrophe_fix
...
fix issue with previews not being displayed if filename contains apostrophe
2015-02-24 09:58:53 +01:00
Jenkins for ownCloud
cdb4cfd939
[tx-robot] updated from transifex
2015-02-24 01:54:58 -05:00
Lukas Reschke
432d7be8cc
Show a empty response for GET on non-files instead of the Browser Plugin
2015-02-23 22:27:23 +01:00
Vincent Petry
5b6caf763c
Removed broken webdav tests
...
The encryption webdav tests are too broad and do not qualify as unit
test. Also, since the sabre upgrade they are not fixable.
The matching functionality is already tested in other classes on a
smaller scale.
2015-02-23 22:27:23 +01:00
Vincent Petry
9f6dcb9d3e
Sabre Update to 2.1
...
- VObject fixes for Sabre\VObject 3.3
- Remove VObject property workarounds
- Added prefetching for tags in sabre tags plugin
- Moved oc_properties logic to separate PropertyStorage backend (WIP)
- Fixed Sabre connector namespaces
- Improved files plugin to handle props on-demand
- Moved allowed props from server class to files plugin
- Fixed tags caching for files that are known to have no tags
(less queries)
- Added/fixed unit tests for Sabre FilesPlugin, TagsPlugin
- Replace OC\Connector\Sabre\Request with direct call to
httpRequest->setUrl()
- Fix exception detection in DAV client when using Sabre\DAV\Client
- Added setETag() on Node instead of using the static FileSystem
- Also preload tags/props when depth is infinity
2015-02-23 22:27:23 +01:00
Lukas Reschke
f54cd14c7e
Merge pull request #14439 from owncloud/fix-ajax-files-external
...
Fix Ajax type casting for files_external
2015-02-23 16:29:45 +01:00
Vincent Petry
4290e1990e
Merge pull request #13829 from owncloud/appmanager-list
...
Better caching for enabled apps
2015-02-23 16:03:32 +01:00
Robin McCorkell
9d36959d82
Fix Ajax type casting for files_external
2015-02-23 14:57:37 +00:00
Thomas Müller
df3c73de72
Merge pull request #14403 from owncloud/update-license-headers
...
Update license headers
2015-02-23 13:53:16 +01:00
Jenkins for ownCloud
6a1a4880f0
Updating license headers
2015-02-23 12:13:59 +01:00
Jenkins for ownCloud
f63b09faca
[tx-robot] updated from transifex
2015-02-23 01:55:10 -05:00
Georg Ehrke
8e02592e3f
fix issue with previews not being displayed if filename contains apostrophe
2015-02-22 16:51:16 +01:00
Jenkins for ownCloud
ef09e5d395
[tx-robot] updated from transifex
2015-02-22 01:54:42 -05:00
Jenkins for ownCloud
906c0e7798
[tx-robot] updated from transifex
2015-02-21 01:54:38 -05:00
Lukas Reschke
6e9a2515ea
Merge pull request #14278 from owncloud/fix-index
...
Check if the offset exists before accessing
2015-02-20 14:56:13 +01:00
Morris Jobke
7cb25149c8
Merge pull request #13645 from owncloud/fix-breadcrumb-backslash
...
Parse backslash as directory separator in breadcrumb
2015-02-20 13:36:38 +01:00
Jenkins for ownCloud
79ef5eda96
[tx-robot] updated from transifex
2015-02-20 01:55:01 -05:00
Lukas Reschke
602e563d99
Merge pull request #14366 from owncloud/remove-old-l10n-files
...
Remove some old l10n files they arent loaded anymore
2015-02-19 23:31:21 +01:00
Thomas Müller
b7ff0d44d8
apply backslash fix to _setCurrentDir
2015-02-19 20:20:33 +01:00
Morris Jobke
75a7bcb10c
Merge pull request #14199 from owncloud/cast-type-manually
...
Manually type-cast all AJAX files
2015-02-19 17:19:54 +01:00
jknockaert
261b5eb90f
again
2015-02-19 16:36:54 +01:00
Thomas Müller
df58eea93f
Merge pull request #13505 from owncloud/streamline-scanning-code
...
Streamline auth and CSRF check in scan.php
2015-02-19 16:35:05 +01:00
jknockaert
9ff9f27f8a
try again
2015-02-19 16:12:01 +01:00
jknockaert
a490e21d0d
new try
2015-02-19 16:10:41 +01:00
jknockaert
417e40d218
Merge remote-tracking branch 'origin/master'
...
Conflicts:
apps/files_encryption/lib/stream.php
2015-02-19 16:08:33 +01:00
jknockaert
d5ba6af259
back
2015-02-19 16:08:08 +01:00
jknockaert
470994ba1e
OC8 version
2015-02-19 15:43:22 +01:00
Joas Schilling
e52a63eccb
Remove some old l10n files they arent loaded anymore
2015-02-19 11:58:40 +01:00
Jenkins for ownCloud
294137dda6
[tx-robot] updated from transifex
2015-02-19 01:55:43 -05:00
Vincent Petry
610761d1f7
Merge pull request #14211 from owncloud/activity/225-files-extension-jenkins
...
Activity/225 Move displaying of files related activities to files app
2015-02-18 14:47:15 +01:00
Vincent Petry
837365fff2
Merge pull request #14210 from owncloud/activity/225-sharing-extension-jenkins
...
Activity/225 sharing extension
2015-02-18 14:46:58 +01:00
Andreas Fischer
c640e2fa66
Update phpseclib to version 0.3.9.
2015-02-18 01:16:23 +01:00
Joas Schilling
0833a6e332
Correctly create activities for public downloads
2015-02-17 17:26:03 +01:00
Lukas Reschke
3213b04aef
Check if the offset exists before accessing
...
This checks if the offset exists before accessing it and also adds unit tests to this function which would have catched this before 🙈
Fixes https://github.com/owncloud/core/issues/14277
2015-02-17 17:08:23 +01:00
Robin Appelman
5394a81c05
Dont fatal error test when encryption is enabled
2015-02-17 15:05:29 +01:00
Jenkins for ownCloud
30ca14021c
[tx-robot] updated from transifex
2015-02-17 01:56:23 -05:00
Morris Jobke
fadf0a9443
Merge pull request #10673 from owncloud/smb-new
...
New SMB storage backend
2015-02-16 17:37:20 +01:00
Robin Appelman
6477e39be9
also make sure we have a leading slash for the test root
2015-02-16 14:01:08 +01:00
Thomas Müller
6cdc7a890a
Merge pull request #14076 from owncloud/autotest-external-ftp
...
[files_external] ftp tests
2015-02-16 13:56:40 +01:00
Robin Appelman
6467369cad
make sure the root has a trailing slash
2015-02-16 13:52:11 +01:00
Robin Appelman
35077ec34e
remove outdated test
2015-02-16 13:52:11 +01:00
Robin Appelman
e98983485f
handle deleting non existing files
2015-02-16 13:52:11 +01:00
Robin Appelman
e5731b6e1a
Use better way to check for the existence of smbclient
2015-02-16 13:52:11 +01:00
Robin Appelman
d2255a1d30
New SMB storage backend
2015-02-16 13:52:11 +01:00
Lukas Reschke
cbe31fbf57
Use `int` instead of `string`
2015-02-16 12:01:05 +01:00
Thomas Müller
d001c4e375
Merge pull request #13922 from owncloud/smb-autotest-external
...
[files_external] add SMB autotest
2015-02-16 10:27:55 +01:00
Jenkins for ownCloud
31c0cce092
[tx-robot] updated from transifex
2015-02-15 01:54:31 -05:00
Jenkins for ownCloud
2f851ff8bb
[tx-robot] updated from transifex
2015-02-14 01:54:42 -05:00
Joas Schilling
200c0c89dc
Do not change behaviour of 'false'
2015-02-13 15:18:07 +01:00
Joas Schilling
d20a8fae45
Move displaying of files related activities to files app
2015-02-13 13:37:10 +01:00
Lukas Reschke
a7df23ceba
Manually type-case all AJAX files
...
This enforces proper types on POST and GET arguments where I considered it sensible. I didn't update some as I don't know what kind of values they would support 🙈
Fixes https://github.com/owncloud/core/issues/14196 for core
2015-02-13 13:33:20 +01:00
Lukas Reschke
9904b30070
Ensure that passed argument is always a string
...
Some code paths called the `normalizePath` functionality with types other than a string which resulted in unexpected behaviour.
Thus the function is now manually casting the type to a string and I corrected the usage in list.php as well.
2015-02-13 12:49:34 +01:00
Roeland Jago Douma
bdd785f5e6
Always display max upload size in admin panel
2015-02-13 11:39:30 +01:00
Joas Schilling
b768a70616
Use filterNotificationTypes to filter the types and group the methods
2015-02-13 11:30:36 +01:00
Joas Schilling
9ccfbc14f6
Copy sharing related activity code to Files_Sharing activity extension
2015-02-13 11:16:43 +01:00
Jenkins for ownCloud
6b1ed4d688
[tx-robot] updated from transifex
2015-02-13 01:55:06 -05:00
Jenkins for ownCloud
e929d43bb6
[tx-robot] updated from transifex
2015-02-12 01:54:41 -05:00
Lukas Reschke
1c1bd058e4
Remove unused file
...
This file is unused and has been last modified two years ago. Furthermore it won't evne work anymore properly because it uses things like `CONFIG_DATEFORMAT` which are gone a long time ago...
2015-02-11 23:26:48 +01:00
Jenkins for ownCloud
9baf7a0a3f
[tx-robot] updated from transifex
2015-02-11 01:55:07 -05:00
Morris Jobke
60cadf5647
[files_external] ftp tests
2015-02-10 22:34:58 +01:00
Morris Jobke
64a3e6eb22
add rreadme for files external tests
2015-02-10 20:43:32 +01:00
Morris Jobke
10e91c6a48
[files_external] sftp tests
2015-02-10 19:53:01 +01:00
Vincent Petry
bd01ff135a
Merge pull request #13190 from is-apps/master-sftp-key
...
Add SFTP public key authentication support
2015-02-10 16:44:29 +01:00
Morris Jobke
f7bbe081b3
[files_external] add SMB autotest
2015-02-10 10:30:10 +01:00
Jenkins for ownCloud
124e48aec0
[tx-robot] updated from transifex
2015-02-10 01:55:06 -05:00
Morris Jobke
1bb6de7c1b
Merge pull request #13425 from owncloud/phpdoc_cleanup
...
Cleanup of PHPDoc return types
2015-02-10 01:14:00 +01:00
Morris Jobke
4a99849c6c
Merge pull request #13663 from owncloud/issue/13624-notification-when-favorting-fails
...
Only update favorite icon if the operation was successful
2015-02-10 00:05:39 +01:00
blizzz
dc475ab3e0
Merge pull request #13925 from owncloud/fix-13898
...
no fruitless count attempts, and notification should disappear
2015-02-09 16:55:50 +01:00
Vincent Petry
2bb65dd9b1
Merge pull request #13364 from is-apps/files_external_cleanup
...
Clean up files_external
2015-02-09 13:20:42 +01:00
Jenkins for ownCloud
e2d4b3c123
[tx-robot] updated from transifex
2015-02-09 01:54:53 -05:00
Jenkins for ownCloud
60e771685e
[tx-robot] updated from transifex
2015-02-08 01:54:53 -05:00
Morris Jobke
108f3327e6
Merge pull request #13502 from owncloud/streamline-authentication-in-newfile
...
Streamline CSRF and login check
2015-02-07 13:27:46 +01:00
Morris Jobke
77c0314503
Merge pull request #13655 from Sugaroverdose/fix_#13632
...
Do not change color of 'new' button on hover and make new file menu more consistent with button
2015-02-07 13:25:43 +01:00
Morris Jobke
57c1b499a1
Merge pull request #13848 from owncloud/ldap-warn
...
Reduce log level of bind failed to WARN - fixes #11624
2015-02-07 13:24:11 +01:00
Morris Jobke
b2f6b8d62e
Merge pull request #13889 from owncloud/catch-exception
...
Catch exception properly
2015-02-07 13:23:34 +01:00
Jenkins for ownCloud
4bf7b2c130
[tx-robot] updated from transifex
2015-02-07 01:54:35 -05:00
Morris Jobke
4e18b52527
Show message if upload of folder isn't allowed
...
* current firefox doesn't throw an exception anymore
* it just reads 0 bytes -> folder or empty file
* upload of folder or empty file isn't supported in every
browser except Chrome
* fixes #13940
2015-02-06 11:15:09 +01:00
Lukas Reschke
a67627140c
Revert "Add OCS sharing info to capabilities"
2015-02-07 00:12:26 +01:00
Frank Karlitschek
0b421e821b
Merge pull request #13692 from rullzer/capabilities
...
Add OCS sharing info to capabilities
2015-02-06 16:46:47 -05:00
Thomas Müller
b4b45a1a52
Merge pull request #13954 from owncloud/fix-enc-mig-user-retrieval
...
Fix enc mig user retrieval
2015-02-06 21:26:32 +01:00
Jenkins for ownCloud
988027fdca
[tx-robot] updated from transifex
2015-02-06 15:26:04 -05:00
Arthur Schiwon
15b2d33599
always specify limit, except you do like questionable surprises
...
always specify limit, except you do like questionable surprises, part 2
2015-02-06 17:51:40 +01:00
Bjoern Schiessle
b2e13229fa
don't check if we have a valid user
2015-02-06 17:31:15 +01:00
Roeland Jago Douma
fe2aca5aa8
Updated unit tests
2015-02-06 12:13:53 +01:00
Roeland Jago Douma
3be3e20c0f
Bit better formatting when using json output
2015-02-06 10:55:33 +01:00
Roeland Jago Douma
d4e361db44
Updated sharing capabilities
...
Moved to files_sharing
Added more capabilities.
Tried to order to capabilities more OO style
2015-02-06 10:33:08 +01:00
Jenkins for ownCloud
bd60abbefc
[tx-robot] updated from transifex
2015-02-06 01:57:07 -05:00
Arthur Schiwon
2bcb786214
no fruitless count attempts, and notification should disappear
2015-02-05 16:25:22 +01:00
Jenkins for ownCloud
9adff77040
[tx-robot] updated from transifex
2015-02-05 01:54:49 -05:00
Lukas Reschke
cc80ce70b4
Catch exception properly
...
`\OCA\Files\Helper::buildFileStorageStatistics` might throw an exception from `OC_Helper::getStorageInfo`, previously this lead to a uncatched exception being thrown when invoking this methods.
This was user triggable by for example calling `/index.php/apps/files/ajax/delete.php` with a not existing dir (for example `dir=asdf/../&allfiles=true`)
2015-02-04 15:58:16 +01:00
Roeland Jago Douma
bcae79a85a
Split up unit tests
2015-02-04 15:49:20 +01:00
Roeland Jago Douma
083ebca812
Added unit test to test getCapabilities for files_sharing
2015-02-04 14:56:31 +01:00
Roeland Jago Douma
0452fde212
Converted getCapabilities to non static function
2015-02-04 14:56:31 +01:00
Roeland Jago Douma
4801d9c02a
Use single quotes
2015-02-04 14:56:31 +01:00
Roeland Jago Douma
ea1f726b7d
Only return capabilities if they are set
2015-02-04 14:56:31 +01:00
Roeland Jago Douma
b3ea849a87
Added capabilities whether a server allows public links
...
This fixes #13673 .
It now lists link sharing, passwords enforced, and if public uploads are
allowed.
2015-02-04 14:56:31 +01:00
blizzz
09216ef49b
Merge pull request #13849 from owncloud/ldap-oc8-update
...
no update routine needed from OC 7 to 8
2015-02-04 14:19:58 +01:00
Jenkins for ownCloud
77e9c212ed
[tx-robot] updated from transifex
2015-02-04 01:55:49 -05:00
Morris Jobke
166c4e266f
Reduce log level of bind failed to WARN - fixes #11624
2015-02-03 11:44:28 +01:00
Arthur Schiwon
02a1cc01b6
no update routine needed from OC 7 to 8
2015-02-03 11:43:47 +01:00
Thomas Müller
a24d73aa0c
Merge pull request #13837 from owncloud/endless-redirect
...
Add callCheck to testremote.php
2015-02-03 11:28:15 +01:00
Jenkins for ownCloud
6aef13fb07
[tx-robot] updated from transifex
2015-02-03 01:54:50 -05:00
Lukas Reschke
4270188252
Add callCheck to testremote.php
...
Without CSRF check this file might be tricked into requesting itself which would result in an endless loop and thus potentially ending in a Denial of Service.
2015-02-02 19:39:41 +01:00
Morris Jobke
1bb8d5978c
Merge pull request #13817 from owncloud/core-apps-dependencies
...
encryption requires openssl and user_ldap requires ldap 🙊
2015-02-02 12:49:45 +01:00
Joas Schilling
12f835b198
toggle back when the action was not performed
2015-02-02 11:17:55 +01:00
Morris Jobke
8e2b99c3a9
fix response for tags and show error message
2015-02-02 11:17:54 +01:00
Joas Schilling
df75a6e5f3
Only update favorite icon if the operation was successful
...
Also shows a notification in case an error occured on updating the tags
2015-02-02 11:17:54 +01:00
Thomas Müller
c9543c9e8e
encryption requires openssl and user_ldap requires ldap 🙊
2015-02-02 09:20:05 +01:00
Jenkins for ownCloud
800829d93d
[tx-robot] updated from transifex
2015-02-02 01:54:32 -05:00
Jenkins for ownCloud
a3067b3b9f
[tx-robot] updated from transifex
2015-02-01 01:54:33 -05:00
Lukas Reschke
012d06e8a2
Merge pull request #13797 from owncloud/fix_move_del_of_remote_shares
...
make sure that we get the correct user from the path
2015-01-31 08:52:07 +01:00
Jenkins for ownCloud
c877fbdac8
[tx-robot] updated from transifex
2015-01-31 01:54:39 -05:00
Bjoern Schiessle
9ef96e4dd5
no need to initialize the same view twice
2015-01-30 14:39:31 +01:00
Bjoern Schiessle
ed29c6ce86
get correct user for paths to the trash bin, needed for remote shares if the size of of trash gets calculated
2015-01-30 14:39:09 +01:00
Morris Jobke
e7900ba255
Merge pull request #13508 from owncloud/failed-delete-cache
...
Dont remove a file from cache if the delete operation failed
2015-01-30 14:08:44 +01:00
Jenkins for ownCloud
f4d20dc1f3
[tx-robot] updated from transifex
2015-01-30 01:55:06 -05:00
Morris Jobke
b1d8d88df8
Merge pull request #13760 from owncloud/create_enc_key_for_remote_shares
...
make sure that we always create a public share key for remote shares
2015-01-29 17:54:04 +01:00
Joas Schilling
333f4e7913
Fix intendation
2015-01-29 16:57:46 +01:00
Joas Schilling
4a5f626979
Fix more assertions
2015-01-29 16:54:27 +01:00
Joas Schilling
9a7dd57bc8
Fix 2 assertions
2015-01-29 16:09:35 +01:00
Thomas Müller
5c8e5e223d
Merge pull request #13728 from owncloud/federated_cloud
...
rename 'server-to-server sharing' to 'federated cloud'
2015-01-29 15:54:19 +01:00
Robin Appelman
ce0aa02aac
Dont do a cache rename if we cant delete the source file
2015-01-29 15:52:40 +01:00
Robin Appelman
215388f4e0
Make sure we delete the file when doing a cross storage trashbin move
2015-01-29 15:40:01 +01:00
Robin Appelman
d4c4e2a322
Detect failed deletes in the trashbin
2015-01-29 15:39:58 +01:00
Bjoern Schiessle
8a091629dc
rename 'server-to-server sharing' to 'federated cloud'
2015-01-29 15:05:39 +01:00
Bjoern Schiessle
c78e3c4a7f
make sure that we always create a public share key for remote shares
2015-01-29 14:23:14 +01:00
Thomas Müller
a25063a8ed
Merge pull request #13746 from owncloud/no-groups-provisioning-api
...
disallow provisioning api to be enabled for groups only
2015-01-29 12:47:54 +01:00
Thomas Müller
099d43b1f9
Merge pull request #13604 from owncloud/encryption-key-migration-as-repair-step
...
adding console command to migrate encryption keys - refs #13450
2015-01-29 10:30:12 +01:00
Thomas Müller
f60406102f
disallow provisioning api to be enabled for groups only
2015-01-29 10:00:54 +01:00
Jenkins for ownCloud
65871ffea3
[tx-robot] updated from transifex
2015-01-29 01:54:35 -05:00
Arthur Schiwon
73600cfdd8
and escape the search term
2015-01-29 00:27:05 +01:00
Arthur Schiwon
953a88785b
💄
2015-01-28 23:57:04 +01:00
Sugaroverdose
e57e273a40
Prevent 1px padding between button and dropdown in ie11 when zooming
2015-01-28 22:44:12 +03:00
Thomas Müller
659f958d01
Merge pull request #13401 from is-apps/amazon_s3_checkboxes
...
Tidy formatting of Amazon S3 checkboxes
2015-01-28 18:50:14 +01:00
Sugaroverdose
0418c9da3d
Play with z-index to make proper dropdown overlap
2015-01-28 20:24:12 +03:00
Arthur Schiwon
31de757514
fix counting of users in primary group
2015-01-28 15:52:59 +01:00
Robin Appelman
a59612752e
Fix trash error when deleting files with the same name at the same time (happens in unit tests)
2015-01-28 15:16:55 +01:00
Arthur Schiwon
323af55b50
inlcude AD primary group in user filter, if a group is selected. fixes #12190
2015-01-28 14:12:12 +01:00
Jenkins for ownCloud
55142186de
[tx-robot] updated from transifex
2015-01-28 01:55:53 -05:00
Morris Jobke
87b39e8f03
Merge pull request #13525 from owncloud/s2s-fixscanfileforbrokenstorage
...
Catch storage exception in scanner for remote shares
2015-01-28 00:31:37 +01:00
Vincent Petry
acec40fe5a
Merge pull request #13561 from owncloud/trash-finaldeletewhencrossstoragefix
...
Call final unlink in trash wrapper's storage
2015-01-27 17:05:38 +01:00
Vincent Petry
3764515365
Allow saving incomplete external storage config
...
This is needed for Dropbox and others that need a token.
2015-01-27 13:44:05 +01:00
Vincent Petry
c4b02176dc
Fix mount config unit test failures
...
Because setStorageId now instantiates storages, they might throw
exceptions if arguments are missing.
This fixes the unit test to not throw exceptions and have their default
config arguments set.
2015-01-27 13:44:05 +01:00
Thomas Müller
1add2f3f58
Merge pull request #13679 from owncloud/public-disablesharejsplugin
...
Disable JS plugin for sharing in public mode
2015-01-27 09:33:38 +01:00
Thomas Müller
29f49ddc3d
Merge pull request #13691 from owncloud/s2s-acceptsinglefile
...
Only reload file list after remote share accept request returns
2015-01-27 09:32:33 +01:00
Jenkins for ownCloud
c8f58054b0
[tx-robot] updated from transifex
2015-01-27 01:54:34 -05:00
Vincent Petry
182b1937bb
Only reload file list after remote share accept request returns
...
When accepting a remote share, an ajax request is sent to the server.
Only once this request returns should the file list be reloaded.
2015-01-26 21:22:22 +01:00
Vincent Petry
efcd89cb18
Do not disclose share owner in public file list
2015-01-26 19:55:48 +01:00
Vincent Petry
86689ef400
Disable JS plugin for sharing in public mode
...
This removes the logic that registers the share action and modifies the
rows. Share actions aren't needed in the public file list.
2015-01-26 19:55:48 +01:00
Vincent Petry
bd888748bd
Merge pull request #13490 from owncloud/fix_reshare_s2s_share
...
use uid provided by setupfs hook to mount server2server shares
2015-01-26 19:54:14 +01:00
Bjoern Schiessle
5ba19ba7fc
certificate manager should always use a \OC\Files\View otherwise we will get problems for different primary storages
2015-01-26 16:58:52 +01:00
Bjoern Schiessle
67da1f7e5a
certificate manager only needs the user-id, no need to pass on the complete user object
2015-01-26 16:58:52 +01:00
Bjoern Schiessle
66f0db30b2
use uid provided by setupfs hook to mount server2server shares, otherwise mount will fail for public link shares
2015-01-26 16:54:50 +01:00
Vincent Petry
d5b61f9afe
Prevent double slash in shareinfo request URL
2015-01-26 16:19:38 +01:00
Vincent Petry
5376b0b123
Add back exit()
2015-01-26 16:07:28 +01:00
Vincent Petry
f6e644b43f
Catch storage exception in scanner for remote shares
...
Whenever an exception occurs during scan of a remote share, the share is
checked for availability. If the storage is gone, it will be removed
automatically.
Also, getDirectoryContent() will now skip unavailable storages.
2015-01-26 13:59:49 +01:00
Vincent Petry
02b9bad81b
Fix bogus deletion on copy + unlink through rename
...
Cross-storage rename would cause copy + unlink. That unlink operation
must not trigger the trashbin.
2015-01-26 12:22:22 +01:00
Joas Schilling
d6939d67da
Remove duplicated definition of APIController
2015-01-26 10:20:01 +01:00
Sugaroverdose
8605e84547
Fix #13632 and make new file menu more consistent with button
2015-01-25 20:15:08 +03:00
Jenkins for ownCloud
a698637e91
[tx-robot] updated from transifex
2015-01-25 01:54:38 -05:00
Lukas Reschke
b848062d88
Parse backslash as directory separator in breadcrumb
...
This will parse backslashes as directory separators in breadcrumbs. Thus when accessing something like `/index.php/apps/files?dir=foo\foo` the breadcrumb will properly resolve this instead of showing `foo\foo`
Fixes https://github.com/owncloud/core/issues/13643
2015-01-24 09:56:00 +01:00
Jenkins for ownCloud
b8e1dd9c87
[tx-robot] updated from transifex
2015-01-24 01:54:51 -05:00
Bjoern Schiessle
73a058e301
by default send mail for new server-to-server share
2015-01-23 21:59:07 +01:00
Vincent Petry
a1cc9eea56
Add trashbin storage wrapper unit test for versions
2015-01-23 18:39:21 +01:00
Vincent Petry
1f39a7aabe
Simplify trash storage unit tests
...
Needed to make it properly init the mount points
2015-01-23 18:08:59 +01:00
Vincent Petry
1a06edd712
Unregister trashbin storage wrapper at the end of tests
...
Some more tests that uses the storage wrapper now remove it afterwards
2015-01-23 15:36:09 +01:00
Robin Appelman
87a1b2bdc4
Preserve mtime when doing cross storage move
2015-01-23 15:11:27 +01:00
Vincent Petry
2e8c70327a
Remove storage wrapper for oc_trashbin in unit test
2015-01-23 14:55:38 +01:00
Robin Appelman
91f3952ac1
Only move files from the current user to the trashbin
2015-01-23 14:19:36 +01:00
Vincent Petry
67f1534e0f
Call final unlink in trash wrapper's storage
...
In the case of cross-storage delete, the files are copied to the trash,
then deleted. The final delete on the source storage would still reach
the trash wrapper.
This fix makes forwards that second call to the wrapped storage to make
the final delete work.
It fixes the issue with remote shares, local shares and external
storage.
Also, it uses a new function "renameRecursive" that renames the files
and preserves the mtimes (like "copy_recursive" did in the past))
2015-01-23 12:20:54 +01:00
Joas Schilling
7e6d2c73d2
Ignore favorites that are not available when creating the favorites list
...
Also correctly return the exception for all cases when adding/removing favos
2015-01-23 10:11:14 +01:00
Jenkins for ownCloud
bc93a8f140
[tx-robot] updated from transifex
2015-01-23 01:55:06 -05:00
Arthur Schiwon
9c7cd702c3
user fs must be setup up, so that the real user folder is mounted on the username based path
2015-01-22 19:16:28 +01:00
Thomas Müller
fc1865449d
adding console command to migrate encryption keys - refs #13450
2015-01-22 16:10:45 +01:00
Jenkins for ownCloud
5f3c6a97b2
[tx-robot] updated from transifex
2015-01-22 01:55:09 -05:00
Morris Jobke
c931eafc1f
Merge pull request #13517 from owncloud/keymanager-storage
...
Bypass the view when storing encryption keys
2015-01-22 00:41:48 +01:00
Morris Jobke
4dac664002
Merge pull request #13568 from owncloud/s2s_delete_shares_jenkins
...
[ignore] delete all server-to-server shares if a user gets deleted
2015-01-22 00:37:39 +01:00
Lukas Reschke
762949afd9
Make naming of encryption app consistent
...
Fixes https://github.com/owncloud/core/issues/13580
2015-01-21 23:29:09 +01:00
Bjoern Schiessle
7216983a08
delete all server-to-server shares if a user gets deleted
2015-01-21 17:11:34 +01:00
Thomas Müller
8ba42abbe4
Merge pull request #13432 from owncloud/animate_gifs_public_sharing
...
show animated gifs on public sharing page
2015-01-21 17:09:46 +01:00
Thomas Müller
9921308c62
Merge pull request #13540 from owncloud/s2s-fixpasswordfromdialog
...
External share dialog must properly read entered password
2015-01-21 16:51:56 +01:00
Vincent Petry
c48307027c
Fixed external cache test namespace
2015-01-21 15:52:56 +01:00
Vincent Petry
9fbdd1072e
Fix webdav mkdir for remote shares
2015-01-21 15:14:57 +01:00
Vincent Petry
f3d696599a
Add unit test for external share JS dialog
...
Moved external share JS code into a small plugin to make it testable.
Added unit test for the external share dialog logic + ajax calls.
2015-01-21 11:26:54 +01:00
Vincent Petry
23ea45760f
External share dialog must properly read entered password
2015-01-21 11:26:36 +01:00
Jenkins for ownCloud
b8ab21d3ad
[tx-robot] updated from transifex
2015-01-21 01:55:15 -05:00
Lukas Reschke
2ed2a7c7a8
Merge pull request #13520 from owncloud/fix-comparison-op
...
this must be larger then (>), since buggy behaviour occurs when the para...
2015-01-20 20:15:04 +01:00
Arthur Schiwon
9cb1ef5675
this must be larger then (>), since buggy behaviour occurs when the parameter is a small number
2015-01-20 17:50:53 +01:00