1a63858095
Merge pull request #13186 from labor4/edit_carddav_types
...
add carddav-search (vCard2Array) option for X-ADDRESSBOOKSERVER-MEMBER
2019-07-02 16:35:25 +02:00
5fbf304c2a
Merge pull request #15777 from nextcloud/feature/ocp-event-dispatcher
...
Add event dispatcher to OCP
2019-06-25 11:48:16 +02:00
3174012adf
Add event dispatcher to OCP
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-06-25 10:02:27 +02:00
ee0e1c4946
add carddav-search option for X-ADDRESSBOOKSERVER-MEMBER
...
Adding field X-ADDRESSBOOKSERVER-MEMBER
which can be used to relate persons to groups (macos behaviour).
- groups are cards with field X-ADDRESSBOOKSERVER-KIND == 'group'
- and all members' UUID/URI in the X-ADDRESSBOOKSERVER-MEMBER array of that group-card.
Signed-off-by: labor4 <schreibtisch@labor4.ch>
2019-06-07 18:03:09 +02:00
08865046fb
log inner exception during dav write
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-06-06 16:02:42 +02:00
49361c40e2
Typehint builtin types in constructor to not initiate autoloading
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-06-04 15:13:33 +02:00
2c5ebac458
Allow to search for real pattern in contacts
...
Added an option escape_like_param to allow wildcards
Signed-off-by: Arne Hamann <kontakt+github@arne.email>
2019-05-28 10:01:56 +02:00
7ec8e6d35b
Don't run repair step for every individual user, outsource that to background job
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-05-23 11:24:32 +02:00
98a93d5226
Revert "send invitations for shared calendars"
...
This reverts commit a9c313ce45
2019-05-22 09:02:25 +02:00
3c78116cf8
do not create folder just to delete it afterwards
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-04-29 16:46:56 +02:00
33946655b9
Merge pull request #15141 from nextcloud/fix/noid/regenerate-seen-users-only
...
fix searching all users in repair regenerate birthday cal reparir job
2019-04-24 19:58:53 +02:00
c16d116fa6
Prefetching blows up if there are a lot of files.
...
I saw instances where people had a lot of files (each with custom
properties) and all this prefetching blew up and started to consume an
insane amount of RAM resulting in the process getting killed.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-04-18 21:23:59 +02:00
1d1c8b4e69
avoids users searches on backend, faster processing
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-04-17 15:55:23 +02:00
592093079f
Deduplicate index names
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-03-27 13:32:59 +01:00
274658629d
Make sure all tables have named indexes
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-03-27 13:32:59 +01:00
d74e49b3e6
implement principal property search for calendar user address set property
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-03-21 16:32:41 +01:00
8ff536f4f7
Merge pull request #14641 from nextcloud/assemblystream-seek
...
make assemblystream seekable
2019-03-15 12:25:28 +01:00
dafbb42189
throw a proper error if rename fails in dav
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-03-14 15:40:21 +01:00
de8e02628e
Improve code
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-03-13 23:01:47 +01:00
6a47f924fc
make assemblystream seekable
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-03-13 16:32:18 +01:00
389c2095a6
Use dependency injection for app manager
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-03-13 00:42:39 +01:00
9bb13fb05f
Created infrastructure to show circles' shared files
...
There is a proposal to allow users to filter files shared to circles. This commit is needed to provide the infrastucture for it.
Issue: https://github.com/nextcloud/circles/issues/137
Changes to comply to https://github.com/coletivoEITA/circles/pull/2
Polishing: get files shared to circles in caldav
Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-03-13 00:31:38 +01:00
f0c85a0f5f
Merge pull request #6512 from coletivoEITA/add_circles_sharing_to_caldav
...
Change CALDAV to allow calendars be shared with circles.
2019-03-13 00:06:46 +01:00
e13253c66a
"Fix" the unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-03-06 11:06:03 +01:00
dd2496b275
Use proper dependency injection for app manager
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-03-05 16:00:47 +01:00
789aaa489d
Fix whitespace
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-03-05 15:48:50 +01:00
8322cec951
Suppress phan exceptions because they are catched by a class_exists
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-03-05 15:46:56 +01:00
eb175584f6
Merge pull request #14514 from nextcloud/fix/no_debug_output
...
Do not just write foobar
2019-03-04 21:26:20 +01:00
79ec7bbcf6
Merge pull request #13871 from PLUTEX/master
...
dav: Fix handling of chunked WebDAV upload
2019-03-04 17:43:31 +01:00
c8d1b29407
Do not just write foobar
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-03-04 17:14:32 +01:00
daee222534
Merge pull request #12978 from tobiasKaminsky/noteOnDav
...
Add note to dav endpoint
2019-03-04 12:58:09 +01:00
aee348c5f5
Update apps/dav/lib/Connector/Sabre/Node.php
...
Co-Authored-By: tobiasKaminsky <tobias@nextcloud.com>
2019-03-04 08:24:14 +01:00
12d3f246aa
use class_exists on correct class to please phan
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-03-04 00:36:52 +01:00
dc26d94014
properly catch exceptions of detailsCircle
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-03-03 23:07:07 +01:00
d6e9a2ea15
Fix dav has-photo plugin extend
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-03-03 19:06:22 +01:00
58c92e6047
Get user's circles without touching session
...
This works with nextcloud/circles#260
Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
2019-03-01 17:04:43 -03:00
34601f8623
allow sharing addressbooks with circles
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-03-01 13:02:30 +01:00
5e37b52241
Share calendar to circle
...
* Allow user to share calendar with a circle
* Allow user to see calendars shared with his/her circles
Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
2019-03-01 10:40:54 +01:00
79d20e4758
Revert 3ff3ed0c56 case-insensitive compares.
...
My oops. The comparisons, which are copied from the IMipPlugin shipped with sabre-io/dav,
do not need to be case insensitive because the sender and recipient names are normalized by sabre,
(see calls to getNormalizedValue in voboject/lib/ITip/Broker.php).
Signed-off-by: Brad Rubenstein <brad@wbr.tech>
2019-02-28 01:43:07 +00:00
6421e30b2c
Respect RSVP parameter for attendees when adding accept/decline buttons.
...
If RSVP=TRUE parameter is FALSE or absent for an ATTENDEE, then do no
present accept/decline buttons. The organizer isn't asking for an RSVP.
Signed-off-by: Brad Rubenstein <brad@wbr.tech>
2019-02-28 01:42:47 +00:00
31a25dc6b0
Customize presentation of accept/decline buttons in iMip mail
...
Fix Issue #11230
Only present accept/decline button links in iMip mail for REQUEST, not CANCEL or others.
Fix Issue #12156
Implement config setting "dav.invitation_link_recipients", to control
which invitation recipients see accept/decline button links. The
default, for public internet facing servers, is to always include
them. For a server on a private intranet, this setting can be set
to the email addresses or email domains of users whose browsers can
access the nextcloud server referenced by those accept/decline
button links. It can also be set to "false" to exclude the links
from all requests.
Signed-off-by: Brad Rubenstein <brad@wbr.tech>
2019-02-28 01:41:48 +00:00
cea53d0a07
Add HasPhoto DAV plugin
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-02-27 09:04:01 +01:00
78e6bf0daf
Add note to dav endpoint
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-02-27 07:11:40 +01:00
2cc4118629
Merge pull request #14066 from nextcloud/feature/noid/casted-system-values
...
Get typed system values
2019-02-22 11:54:20 +01:00
0c77cd21f9
Make sure maintenance mode is always casted to bool
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-02-22 08:25:41 +01:00
4c8cfd224c
Merge pull request #14299 from nextcloud/fix/14298/fix_storages_not_closing_handle
...
Hanlde writestream not closing source
2019-02-20 10:28:21 +01:00
2b76e27aad
Merge pull request #11832 from nextcloud/bugfix/9849/birthday_without_year
...
set birthday year to 1970 if no year, take X-APPLE-OMIT-YEAR into account
2019-02-20 10:16:47 +01:00
719b70108d
Hanlde writestream not closing source
...
Fixes #14298
If a storage doesn'tclose the write stream then $isEOF is not yet set.
So we have to fallback.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-20 09:49:06 +01:00
fc967a5ac2
Make sure that we have a stream
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-18 14:25:57 +01:00
3acde071f3
Add Repair step to regenerate birthday calendar
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-02-16 16:19:22 +01:00
58520209be
unicode all the birthday icons
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-02-16 13:25:08 +01:00
9d0ce12970
set birthday year to 1970, take X-APPLE-OMIT-YEAR into account
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-02-16 12:33:38 +01:00
3720add736
Add a wrapper to determine if a file is EOF
...
The stream is already closed at this point. Which means feof will always
return false. We have to determine if the stream is EOF in the
preCloseCallback. And pass this info along. Then the logic works as
expected.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-15 08:41:39 +01:00
87c8a71647
Merge pull request #10068 from nextcloud/feature/1434/provisioning_profiles_for_dav
...
Add Apple Provisioning profile
2019-01-31 11:25:39 +01:00
9d285c4459
Fix theming defaults injection if theming app is disabled
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-01-31 09:53:45 +01:00
16fec60e8f
Add Apple Provisioning profile
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-01-30 19:50:02 +01:00
2764173d09
Use proper mime type for ico
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-01-28 21:41:26 +01:00
4dbef1210c
Add ico as avatar
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-01-28 21:41:26 +01:00
554c78c9b1
Merge pull request #5881 from nextcloud/command-move-calendar
...
Add command to move a calendar from an user to another
2019-01-28 17:35:13 +01:00
9348e3d2f6
dav: Fix handling of chunked WebDAV upload
...
When $data is null (which can happen when $request->getBodyAsStream() returns
null), the Exceptions says "copied bytes: 0, expected filesize: 0", which
sounds more like success...
2019-01-28 17:14:22 +01:00
22112bf71d
Allow access to addressbook unique uri
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Co-Authored-By: Joas Schilling <coding@schilljs.com>
2019-01-22 10:03:56 +01:00
cec72536de
Merge pull request #13511 from nextcloud/bugfix/noid/remove-orphan-event-and-contact-data
...
Remove orphan event and contacts data
2019-01-16 22:54:40 +01:00
3180ddd202
Handle moving calendar to an user who already has the share
...
Extra:
* Fix @ChristophWurst style remarks
* Add a Note that share links have changed when calendars has user shares (see #13603 )
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Fix forgotten test change
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2019-01-16 13:58:34 +01:00
4864b1865b
Don't check group shares if shareWithGroupMembersOnly is false
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Remove the system user check
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2019-01-16 13:58:34 +01:00
4a2238c75b
add list-calendars command
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Rebase and delete URI suggestion part
Invite to use occ dav:list-calendars instead
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Fix autoload
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Use injection & test everything
And rebase
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Add test for ListCalendars and refactoring
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Fix indentation
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2019-01-16 13:58:33 +01:00
943d48cb3e
Add command to move a calendar from an user to another
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Add a basic check for displaynames in case we fail to get calendar from uri and put some sf console styles & refactor a bit
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
basic Tests
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
add forgotten createNamedParameter()
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2019-01-16 13:58:33 +01:00
4149d428d3
Principals can be principal/user/<name> or principal/<name> from legacy installs
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-14 11:21:41 +01:00
f88e7648d5
Remove orphan event and contacts data
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-11 13:03:53 +01:00
12e24ed6e7
Check for no longer existing calendars
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-11 09:46:55 +01:00
7d9f12a29c
Prevent php info about missing index for old events
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-09 14:43:51 +01:00
8593edd66d
Merge pull request #13430 from nextcloud/bugfix/13331/respect-classification-of-calendar-events-in-activity-stream
...
Respect classification of calendar events in activity stream
2019-01-09 10:03:23 +01:00
9f2d14447f
Add a repair step to remove sensitive event activity
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-08 18:39:40 +01:00
32d76c7c92
Correctly handle the classification of events in the activity stream
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-08 17:46:07 +01:00
2bd98daaa2
Merge pull request #12227 from nextcloud/bugfix/cleanu_upload_folders
...
Background job to cleanup leftover chunked uploads
2019-01-07 11:19:43 +01:00
846d21e7f5
Merge pull request #13117 from nextcloud/vcard-avatar-fixes
...
Allow URI as data for vcard PHOTO
2019-01-04 21:33:59 +01:00
7f5c38bb60
Update apps/dav/lib/CardDAV/PhotoCache.php
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Co-Authored-By: skjnldsv <skjnldsv@users.noreply.github.com>
2019-01-04 20:04:13 +01:00
1d2d7fd60d
Log failure on parsing
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-01-04 20:04:13 +01:00
fa6c257084
Allow URI as data for vcard PHOTO
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-01-04 20:04:13 +01:00
4535cc50ad
check anonymous OPTIONS requests file in root (not in subdir)
...
Signed-off-by: Bastien Durel <bastien@durel.org>
2019-01-04 18:42:42 +00:00
adb2b9a2f8
Add live repair step to cleanup old chunks
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-04 09:21:21 +01:00
cb742e7045
Background job to cleanup leftover chunked uploads
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-04 09:21:21 +01:00
e7950a5bd6
Merge pull request #12693 from nextcloud/fix/11474/fix-first-ldap-login
...
fix exception on LDAP mapping during login
2018-12-17 13:07:21 +01:00
d41d3d8bf3
If the parent is not cached we should request the file
...
Else we ignore all incomming shares. Which basically does 💥
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-06 21:59:28 +01:00
8ddc0de2f4
Merge pull request #12814 from nextcloud/fix/9058/no_user_enumartion_if_disabled
...
No user enumeration on DAV if disabled
2018-12-05 20:58:29 +01:00
d8314b102e
Merge pull request #12624 from nextcloud/bugfix/noid/validate-all-rich-objects
...
Validate all rich objects
2018-12-04 22:48:54 +01:00
58ca6b1554
No DAV user enumeration if disabled
...
Fixes #9058
If the option to autocomplete users is disabled. We also should not
enumerate the users on this endpoint.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-04 15:33:07 +01:00
64716dd569
Merge pull request #12813 from nextcloud/fix/system_address_book
...
Fix the system address book
2018-12-04 15:19:49 +01:00
29eff7b122
Fix the system address book
...
c23a66cda4
2018-12-04 13:33:03 +01:00
28474612e4
Only run the AnonymousOptionsPlugion on Anonymous requests
...
Fixes #12744
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-04 11:55:04 +01:00
ea283c0248
be careful with mixed return values even if it may look unsuspicious…
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-11-27 17:16:58 +01:00
ffd7778040
extend anonymous options to work on every dav url
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-11-23 15:36:40 +01:00
99bcc1363e
Fix wrong used type
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-23 12:39:02 +01:00
35251928d5
forward object not found error in switch as dav 404
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-11-19 11:34:38 +01:00
a4d81ba164
Merge pull request #12458 from nextcloud/bugfix/dav_shares_hickup
...
fixes dav share issue with owner
2018-11-15 13:32:54 +01:00
d70b010432
Merge pull request #12447 from nextcloud/bugfix/12446/fix-oracle-install-again
...
Shorten index name of calendar changes table
2018-11-15 10:47:51 +01:00
c23a66cda4
fixes dav share issue with owner
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-11-14 21:49:00 +01:00
5a5d46b1b8
Load apps that have a dav type set before the dav server plugins
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-14 11:01:42 +01:00
aa88254f64
Shorten index name of calendar changes table
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-14 10:14:23 +01:00
3c5e43898e
Merge pull request #12275 from nextcloud/bugfix/11975/oracle_calendar_subscriptions_source
...
Fix Calendarsubscriptions source column change on Oracle
2018-11-13 16:34:32 +01:00
071301bfb9
Fix Calendarsubscriptions source column change on Oracle
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-11-13 16:32:47 +01:00
fd8eeccb15
Merge pull request #11942 from nextcloud/techdebt/noid/use-count-function
...
Use the defined func()->count() instead of manual counting
2018-11-12 17:43:56 +01:00
e18548ce75
Fix displayName return of dav groups request
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-10 13:34:07 +01:00
bb352fb667
Use the defined func()->count() instead of manual counting
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-08 15:44:45 +01:00
30d13bb760
cache webcal calendars on server
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-11-07 13:25:14 +01:00
665a6d2055
Allow writing an empty file with the new writeStream
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-05 17:00:04 +01:00
b6d8c5ff2f
Add check for vCard uid
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-05 12:49:39 +01:00
934d08b2e8
Merge pull request #12004 from nextcloud/dl-vcf-groups-plugin
...
Multi vcf download plugin
2018-11-05 10:16:30 +01:00
dcddccb004
Merge pull request #12265 from nextcloud/dav-bump
...
bump dav version for migration
2018-11-05 09:05:32 +01:00
a6c8fe099d
bump dav version for migration
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-05 08:11:31 +01:00
60d8b56856
Added multi-get vcf download plugin
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-04 20:01:49 +01:00
5d3051ff62
Do not log FileLock as exception
...
There is no reason to log FileLock errors as exceptions to the log file.
Locks happen for very legit reasons and it is actually a sign of the
code doing its job.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-04 13:55:49 +01:00
9d89f8bbac
Merge pull request #12071 from nextcloud/addressbook-uid-check-migration
...
Addressbook uid check migration
2018-11-02 19:37:48 +01:00
66624cfe0a
Phpunit fix
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-02 14:20:53 +01:00
7ba8700ba1
Merge pull request #12148 from nextcloud/suppress-wrong-audit-log-message
...
suppress wrong audit log messages about failed login attempts
2018-11-02 13:52:50 +01:00
7246f2ace5
Update PHPDoc to reflect the actual behaviour
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-01 15:02:50 +01:00
d89edb28c4
move migration
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-01 15:02:50 +01:00
9afff2fb20
Properly set uid and create and update
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-01 15:00:49 +01:00
9b3cc72f7c
fix writeStream for jail wrapper
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-31 21:10:57 +01:00
93de63777e
extend storage api to allow directly writing a stream to storage
...
this removes the need for temporary storages with some external storage backends.
The new method is added to a separate interface to maintain compatibility with
storage backends implementing the storage interface directly (without inheriting common)
Currently the interface is implemented for objectstorage based storages and local storage
and used by webdav uploads
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-31 21:10:44 +01:00
0efd29f41f
first check if the user is already logged in and then try to authenticate via apache, this way we suppress wrong audit log messages about failed login attempts
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-10-30 22:14:52 +01:00
1293affc84
Merge pull request #12020 from nextcloud/bugfix/11795/calendar_invitation_fallback_lang
...
Calendar invitation: use system default instead of sender's language as fallback
2018-10-30 22:05:20 +01:00
b9c5e569d3
Update AddressBookImpl documentation
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 14:43:08 +01:00
61af607525
Make enhancing entries with type property optional
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:35 +01:00
8b92a6c9cb
Add type of properties to address book results
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:34 +01:00
45d8aeb9f2
Remove federated sharing address books which are the same as local ones
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:33 +01:00
70e4884e02
Implement the size of an assembly stream
...
This will make it possible to act propely on moves of future files if we
need to know the size (like for max size virus scanning).
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-26 10:43:11 +02:00
5c51d84a67
Calendar invitation: use system default instead of sender's language as fallback
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-24 18:39:30 +02:00
b853102a8f
Merge pull request #11886 from nextcloud/feature/noid/principal_search_displayname
...
Principal property search for users and groups with {DAV:}display name
2018-10-23 21:26:31 +02:00
2f518b6ac8
lazy open first source stream in assemblystream
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-22 16:11:13 +02:00
5cfb5ec176
allow group principal search for dav displayname property
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:18 +02:00
218253db76
allow user principal search for dav displayname property
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:18 +02:00
10f0296ad6
overwrite Sabre/DAV's handler for calendar-user-type to report correct user type
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:18 +02:00
325e366b58
add correct calendar-user-type to resource and room backend
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:13 +02:00
543c863434
Merge pull request #11931 from nextcloud/bug/do_not_emit_pre_hooks_twice_objectstore
...
Do not emit preHooks twice on non-part-storage
2018-10-19 19:56:42 +02:00
851f525889
Merge pull request #11668 from nextcloud/bugfix/7726/convert_caldav_subscription_source_to_long_text
...
convert source column in calendarsubscription table to (long) text
2018-10-19 15:49:17 +02:00
b51e503aea
Do not emit preHooks twice on non-part-storage
...
The old code would emit the hooks twice. Thus having the version written
twice. Which is not very performant as it is first read twice as well.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-19 12:19:53 +02:00
4e53ea6dbd
Merge pull request #11822 from nextcloud/bugfix/noid/forbid_freebusy_but_allow_local_delivery
...
allow local delivery of schedule message while prohibiting FreeBusy requests
2018-10-18 11:35:51 +02:00
f5dc7b7f07
move disableFreeBusy check from User principal backend to Scheduling Outbox collection. This allows to keep local delivery of scheduling messages while prohibiting FreeBusy requests
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-16 20:27:33 +02:00
b458ed9c82
Properly escape column name in "createFunction" call
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-16 15:24:02 +02:00
b83918ed6d
convert source column in calendarsubscription table to (long) text
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-15 13:16:31 +02:00
ea21aa3f7a
Use numeric placeholders if there are multiple, so that RTL languages can operate better
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-09 14:32:14 +02:00
1c6f666bbf
adjust Calendar resource / room interfaces to use class implementation
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-08 01:25:20 +02:00
8743fe6bba
Merge pull request #11435 from nextcloud/assemblystream-node-to-small
...
throw an error if a node is smaller than expected in assemblystream
2018-10-01 18:12:49 +02:00
f1f74a39b6
throw an error if a node is smaller than expected in assemblystream
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-28 15:40:08 +02:00
6b7a69752c
AssemblyStream is also eof if we have no more source stream
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-28 15:09:43 +02:00
83639a9898
remove LogicException, because it's also triggered with legitimate parameters
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-09-05 14:10:26 +02:00
3806ecb242
use the same ignored properties list for both CustomerPropertiesBackends
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-28 18:27:53 +02:00
e2a64c713f
cast timestamps older than unix epoch to 0
...
This change solves issues #10870 , which is caused by method castValue of class FileSearchBackend: It casts the timestamps older than the unix epoch to false., see my comment https://github.com/nextcloud/server/pull/10835#discussion_r212806153 .
2018-08-27 07:44:24 +02:00
b76e6be441
disallow negative mtime in dav search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-24 16:20:07 +02:00
7aad5b7721
Merge pull request #10543 from nextcloud/ignore-deactivated-users
...
Do not show deactivated users in sharees and contacts
2018-08-10 15:01:14 +02:00
523fdb612c
Add room shares to DAV and recent files "share-types" property
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
c05a0b9fa6
Adding test for table schedulingobjects and fixing postgres LOB
...
(cherry picked from commit afd4ebf0404e8bcd7cba0bec2dce177e97632f8a)
Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
2018-08-06 13:53:32 +02:00
a311798674
Remove users from system addressbook when user deactivated
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-08-06 09:30:21 +02:00
6c5670f6d2
Update IMipPlugin.php
...
Added space before ellipsis
2018-07-30 15:05:55 +02:00
c94ac53e60
Typo fix: Triple dot to ellipsis
...
Signed-off-by: Mark Ziegler <mark.ziegler@rakekniven.de>
2018-07-29 10:15:02 +02:00
1a156c298e
Replace contacts-dark icon with contacts
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-24 18:47:54 +02:00
a2df728fb8
Merge pull request #9581 from nextcloud/dav-acl-no-files
...
disable dav acl plugin for files resource
2018-07-20 12:16:45 +02:00
14bc9ffda4
Fixed tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:59 +02:00
d4a51447d1
Fix getting ocs share permissions if a storage is not available
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-18 14:42:39 +02:00
daed1bed57
Also shorten the name of the invitation tokens
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-12 12:11:11 +02:00
b7de6d7a24
Shorten resource table names to allow install on oracle again
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-12 11:55:19 +02:00
d9aa5ed96d
Merge pull request #9942 from nextcloud/feature/2338/invitation_response_in_email
...
Include accept / decline links in CalDAV invitation emails
2018-07-11 19:53:22 +02:00
8399d6070e
always log exceptions on dav write
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-09 14:25:54 +02:00
7025f16017
Merge pull request #9345 from nextcloud/federation20
...
Federation 2.0
2018-07-03 23:13:47 +02:00
27089422e1
Improved logging of smb connection errors
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-03 14:56:37 +02:00
6e9dbe7d15
Merge pull request #10078 from nextcloud/bugfix/activity-277/invalid-actor-and-calendar-for-link-shares
...
Correctly parse the subject parameters for link (un)shares of calendars
2018-07-02 15:43:36 +02:00
a0a6aff772
Correctly parse the subject parameters for link (un)shares of calendars
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-02 13:57:48 +02:00
1f9f5e2e5e
Fix lazy search backend
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-02 13:42:41 +02:00
cdf8abb060
look for correct OCM permissions
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:31 +02:00
4aa4e4080c
Include accept / decline links in CalDAV invitation emails
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-29 10:44:44 +02:00
79f16f9d46
Merge pull request #10037 from nextcloud/dav-options-search
...
Fix search related results in OPTIONS requests
2018-06-29 09:36:12 +02:00
89b6ee1a45
Merge pull request #9773 from nextcloud/feature/noid/resource_booking
...
resource booking
2018-06-29 06:51:49 +02:00
b21bec5c73
Fix search related results in OPTIONS requests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-28 14:54:46 +02:00
f3949cf1a8
Add groupware settings section
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-27 19:16:21 +02:00
cba783f5df
Calendar resource booking: unit tests / adding missing annotations
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:59:04 +02:00
8f061f5407
periodically query calendar resource / room backends for updated resource / room information
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:59:01 +02:00
b832edabbf
apply group restrictions to resources
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:58:07 +02:00
2da510af0b
add resource / room principals
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:58:07 +02:00
f017f431f6
properly lock the target file on dav upload when not using part files
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-11 15:26:41 +02:00
7ea41a1461
enable caldav for webdav subtree public-calendars
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-08 13:12:34 +02:00
ea4f4b8417
Add sabre plugin to allow anonymous options requests to the dav root
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-01 17:20:42 +02:00
f5e16dfaa7
Merge pull request #9609 from nextcloud/bugfix/3830/invitations_for_shared_calendars
...
send invitations for shared calendars
2018-06-01 12:40:53 +02:00
c3fc789b2c
Merge pull request #9550 from nextcloud/bugfix/noid/override_freebusy_sharing_rules
...
allow admins to disable FreeBusy without modifying ShareAPI capabilities
2018-06-01 12:00:56 +02:00
7f301be188
Merge pull request #9583 from nextcloud/files-home-userfolder
...
use getUserFolder instead of getFileInfo when constructing FilesHome
2018-05-29 16:50:01 +02:00
26c1e33d11
Move repairstep to a custom command
...
People that have issues can run it manually
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-28 13:26:55 +02:00
8bf8e92092
Adding repair step which cleans shares of invalid principals
...
edacf22fbc
2018-05-27 20:51:36 +02:00
69e650d0e8
CalDAV and CardDAV plugins need to be registered for the principals collection as well
...
9f2e6431b8
2018-05-27 20:51:36 +02:00
240006bdf5
When sharing calendars and addressbooks the principal has to be verified to be valid
...
d3fb8fcdd3
2018-05-27 20:51:36 +02:00
c5d5c7dc12
Do not load calendar/addressbook plugins if not needed
...
Fixes #6711
Based on f0fb21cf35
2018-05-27 20:51:32 +02:00
a9c313ce45
send invitations for shared calendars
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-05-25 20:41:50 +02:00
51724a35a4
use getUserFolder instead of getFileInfo when constructing FilesHome
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-24 14:17:53 +02:00
491f01efba
disable dav acl plugin for files resource
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-24 14:00:14 +02:00
367ca563b4
allow admins to override FreeBusy capabilities without modifying ShareAPI capabilities
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-05-22 19:16:26 +02:00
d161d4473e
Merge pull request #9029 from nextcloud/settings-restructure
...
Restructure server settings
2018-05-07 12:29:53 +02:00
7cb467b476
Merge pull request #9355 from nextcloud/dav-upload-lock
...
only allow a single concurrent dav write to a file
2018-05-03 16:28:39 +02:00
a77efe0a55
Move dav settings to main server settings
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:22 +02:00
a56ec1062a
Merge pull request #9346 from nextcloud/techdep/noid/needsPartFile_to_storage
...
Use an actual function of the storage to determine needsPartFile
2018-05-02 16:03:31 +02:00
953691abb2
External mount does not get DELETE and UPDATE if readonly
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-01 15:18:56 +02:00
055a003661
Use an actual function of the storage to determine needsPartFile
...
We have a function for it so better to override that. Also because other
codes that might check this should get the right value.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-01 15:02:36 +02:00
f212c692ac
Merge pull request #9178 from nextcloud/feature/9142/directdownload
...
Add directdownload endpoint
2018-05-01 14:54:44 +02:00
dd1b0799a4
only allow a single concurrent dav write to a file
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-26 11:16:51 +02:00
38a90130ce
move log constants to ILogger
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 10:45:52 +02:00
1c75ddac45
Improve the directContoller
...
* Tests
* No directdownload from storage yet (as it is not tested at all)
* No direct links for folders
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:38 +02:00
d5222d68f0
Add tests for DirectFile and DirectHome
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
392337fa13
Throttle requests to unknown tokens
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
b6c58e75b7
Add backgroundjob to cleanup expired direct links
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
042340ccf6
Check if a direct link is expired
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
6a385dd20b
Add directDownload support of storage
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
164d998856
No listing
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
b3e7865d9b
Dav endpoint returns proper data
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
5c6d3b4f41
Request a direct link
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
f984664bee
First step of DAV endpoint
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
9ab5b6a4f1
Add DB mapping
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
b0c801c764
Add directdownload table
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
dd34cb7540
Less deprecated calls to OCP\Util::writeLog
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-22 20:41:49 +02:00
bc3fde9f75
log more information about insufficient storage in dav plugin
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-17 15:29:37 +02:00
fed9140abd
Merge pull request #9148 from nextcloud/dav-read-exception
...
transform exception during file read to sabre exceptions
2018-04-11 16:03:12 +02:00
2626d11f78
Merge pull request #9097 from nextcloud/bugfix/7661/use_mb_substr
...
Use multibyte substring
2018-04-11 15:55:55 +02:00
e6a7ddc1c6
transform exception during file read to sabre exceptions
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-11 14:45:35 +02:00
0864d1c51d
Use multibyte substring
...
Fixes #7661
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-05 22:26:38 +02:00
373a1d5391
more consistent naming
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 12:46:15 +02:00
2ebf26e444
admin_audit and dav listen to announce and revoke signals
...
also place them in doc
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 12:38:43 +02:00
bd8352d4c4
Merge pull request #8996 from brandonkirsch/fix-onenote-dav
...
Fix webdav support for OneNote clients
2018-04-03 13:27:29 +02:00
e8b7e9e75d
Do not treat is-encrypted as customer property
...
fixes #8977
Else for all files in a folder we would launch off more queries.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-28 08:34:50 +02:00
c5005bbab5
Fix webdav support for OneNote clients
2018-03-26 15:32:12 -04:00
e6a2c13ac1
MethodNotAllowed is not a Fatal error
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 12:15:31 +02:00
c306bc29d1
Make displayname selectable
...
It is dav. so if it is not properly set we just return a 404 anyway.
2018-03-22 16:46:21 +01:00
208e38e84e
Merge pull request #8255 from nextcloud/bugfix/noid/group-display-name
...
Full implement group display names
2018-03-15 12:07:30 +01:00
ed5008597f
Merge pull request #8112 from nextcloud/fix-integer-overflow
...
Fix integer overflow in ChunkingPlugin
2018-03-09 10:27:17 +01:00
db9b2398dd
Fix group displaynames in activity
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:49 +01:00
f5ef9e02b2
emit pre-hooks earlier when not using part files
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-03-08 13:02:35 +01:00
fc4e0501f0
Fix integer overflow in ChunkingPlugin
...
Avoids errors when the size exceeds MAX_INT because of the cast to int. Better cast it to float to avoid this.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-06 18:47:26 +01:00
236086c457
Merge pull request #8335 from nextcloud/remove-unused-import
...
Remove unused import statements
2018-02-14 22:23:07 +01:00
d3d045dd5c
Remove unused import statements
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-14 16:55:43 +01:00
e2974f1133
Simplify return statement
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-13 21:55:24 +01:00
e5c08621af
Merge pull request #8023 from nextcloud/webdavsearch_limit_order_fixing
...
Respect limit and order in webdav search
2018-02-08 09:11:39 +01:00
c1ff12e234
CacheJail should apply limit and offset after searching
...
Else the results might not be correct.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-07 13:41:15 +01:00
6b5419ddf0
Adjust to updated searchdav library
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-07 13:41:15 +01:00
ec144281ef
Respect limit and order in webdav search
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-07 13:41:15 +01:00
9d6d23d1f7
keep previous exception when transforming to dav exception
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-07 13:34:30 +01:00
9896b15ec8
Only handle encrypted property on folders
...
Exposing the encrypted property is required for E2E. However, there is
no need to expose this on files as then it is server side encryption
(which the clients don't care about).
Better to not confuse the output.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-30 12:25:49 +01:00
eb51f06a3b
Use ::class statement instead of string
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-29 12:03:47 +01:00
a661f043e1
Remove unneeded semicolon and parentheses
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 23:46:40 +01:00
97c216ea06
Merge pull request #8071 from nextcloud/remove-silly-code
...
Cleanup unused code
2018-01-26 15:47:06 +01:00
c67736a542
Merge pull request #7707 from nextcloud/bugfix/noid/birthdaycalendar-different-uids
...
generate different UIDs for Birthday, Anniversary and Death event
2018-01-26 15:46:46 +01:00
c005fc6755
Cleanup unused code
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 15:25:19 +01:00
c1e4f9f305
Use type casting instead of *val() method
...
It should be up to 6x faster
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 11:35:42 +01:00
c2b1bd92d6
Merge pull request #8063 from nextcloud/inline-value
...
Return value immediately instead of assigning to a one-time variable
2018-01-26 10:15:39 +01:00
ec1d94c629
Merge pull request #8052 from nextcloud/fix-array-methods
...
Fix array method usages with a proper call
2018-01-26 09:53:13 +01:00
0a56d2185e
Return value immediately instead of assigning to a one-time variable
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 00:02:03 +01:00
Morris Jobke
Roeland Jago Douma
Christoph Wurst
labor4
Robin Appelman
Roeland Jago Douma
Arne Hamann
Georg Ehrke
Arthur Schiwon
Joas Schilling
Vinicius Cubas Brand
Christoph Wurst
John Molakvoæ (skjnldsv)
Brad Rubenstein
tobiasKaminsky
Joas Schilling
Daniel Kesselberg
Jan-Philipp Litza
Thomas Citharel
Bastien Durel
Julius Härtl
John Molakvoæ
Bjoern Schiessle
Christian
Daniel Calviño Sánchez
Thomas Müller
rakekniven
Brandon Kirsch